Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. #16496

Merged
ahsonkhan merged 1 commit into from
Feb 22, 2018
Merged

Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. #16496

ahsonkhan merged 1 commit into from
Feb 22, 2018

Conversation

@ahsonkhan
Copy link

@ahsonkhan ahsonkhan commented Feb 22, 2018

Update to #16379

Ran the new tests locally on OSX and they all pass now.

Fixes the test failures - https://mc.dot.net/#/user/ahsonkhan/pr~2Fjenkins~2Fdotnet~2Fcorefx~2Fmaster~2F/test~2Ffunctional~2Fcli~2F/e0a26daab80419c10a37646444d5155d5495d241/workItem/System.Memory.Tests/wilogs

System.SpanTests.ReadOnlySpanTests.LengthMismatchToLower [FAIL]
2018-02-22 03:47:55,702: INFO: proc(54): run_and_log_output: Output:       Assert.Equal() Failure
2018-02-22 03:47:55,703: INFO: proc(54): run_and_log_output: Output:       Expected: Char[] ['a', 'b', 'c', 'D']
2018-02-22 03:47:55,703: INFO: proc(54): run_and_log_output: Output:       Actual:   Char[] ['a', 'b', 'c', '\0']

Related PR: dotnet/corefx#27193

cc @jkotas, @stephentoub, @KrzysztofCwalina, @tarekgh, @JeremyKuhne

@ahsonkhan ahsonkhan self-assigned this Feb 22, 2018
@ahsonkhan ahsonkhan mentioned this pull request Feb 22, 2018
Merged
@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 22, 2018

@dotnet-bot test Ubuntu arm64 Cross Debug Innerloop Build

@ahsonkhan
Copy link
Author

ahsonkhan commented Feb 22, 2018

@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test

@ahsonkhan ahsonkhan merged commit 9e7ec66 into dotnet:master Feb 22, 2018
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Feb 22, 2018
@ahsonkhan @dotnet-bot
Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. (dotnet/coreclr#16496
892e25c 
)

Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Feb 22, 2018
@ahsonkhan @dotnet-bot
Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. (dotnet/coreclr#16496
3cc967b 
)

Signed-off-by: dotnet-bot <[email protected]>
jkotas pushed a commit to dotnet/corefx that referenced this pull request Feb 22, 2018
@ahsonkhan @jkotas
Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. (dotnet/coreclr#16496
487060b 
)

Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
jkotas pushed a commit to dotnet/corert that referenced this pull request Feb 22, 2018
@ahsonkhan @jkotas
Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. (dotnet/coreclr#16496
836dc8b 
)

Signed-off-by: dotnet-bot <[email protected]>
@ahsonkhan ahsonkhan deleted the FixForUnix branch February 22, 2018 18:24
kbaladurin pushed a commit to kbaladurin/corert that referenced this pull request Mar 15, 2018
@ahsonkhan
Fix impl of ReadOnlySpan ToLower/ToUpper for Unix. (dotnet/coreclr#16496
75ac6bf 
)

Signed-off-by: dotnet-bot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ahsonkhan ahsonkhan

Labels

area-System.Memory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ahsonkhan