This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Dial back aggressive checks in Path #16447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators
JeremyKuhne
added
* NO MERGE *
JeremyKuhne
requested review from
Anipik,
danmoseley,
maryamariyan and
pjanotti
JeremyKuhne
added a commit
to JeremyKuhne/corefx
that referenced
this pull request
Feb 20, 2018
danmoseley
reviewed
Feb 20, 2018
|
|
||
| // The resulting string is null if path is null. If the path is empty or | ||
| // only contains whitespace characters an ArgumentException gets thrown. | ||
| public static string GetPathRoot(string path) |
Anipik
approved these changes
Feb 20, 2018
Remove other usages of PathSkip (related to dotnet#16311)
JeremyKuhne
added a commit
to dotnet/corefx
that referenced
this pull request
Feb 21, 2018
* Test updates for dotnet/coreclr#16447 * Move variant test to own method. Add GetFileName tests for volume separators.
Member
Author
|
Test updates were merged: dotnet/corefx#27270 |
JeremyKuhne
removed
the
* NO MERGE *
Member
Author
|
@dotnet-bot test Tizen armel Cross Checked Innerloop Build and Test Timed out |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Feb 21, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot <[email protected]>
JeremyKuhne
added a commit
to dotnet/corert
that referenced
this pull request
Feb 21, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot <[email protected]>
Member
|
@Anipik The mirror skipped this PR, and also dotnet/corefx#27328 . Could you please take a look ? |
|
@jkotas I will add the commit after dotnet/corefx#27381 has merged |
It has been merged. |
Member
|
@Anipik This one was still not mirrored yet. Could you please take a look? |
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 23, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Feb 23, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
Merged
kbaladurin
pushed a commit
to kbaladurin/corert
that referenced
this pull request
Mar 15, 2018
* Dial back aggressive checks in Path Aggressive checks are preventing crossplat and extended Windows solutions. This change: - Doesn't throw on empty paths fro GetDirectoryName, GetPathRoot - Doesn't consider colon when looking at path segments on Windows - Moves non-shared code out of PathInternal - Fix span GetDirectoryName to handle multiple separators * Comment updates * Check for valid drive letter with PathRoot Remove other usages of PathSkip (related to #16311) Signed-off-by: dotnet-bot <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Test updates for dotnet/coreclr#16447 * Move variant test to own method. Add GetFileName tests for volume separators. Commit migrated from dotnet/corefx@24334bf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggressive checks are preventing crossplat and extended Windows solutions. This change:
I've marked this as no merge- I'll be linking in the necessary test fixes (not many).