This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use Math.Clamp rather than Min(Max( #16219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Feb 6, 2018
| // - But this is only up to a maximum, so we stay in the small object heap, and never allocate | ||
| // really big chunks even if the string gets really big. | ||
| int newBlockLength = Math.Max(minBlockCharCount, Math.Min(Length, MaxChunkSize)); | ||
| int newBlockLength = Math.Clamp(Length, minBlockCharCount, MaxChunkSize); |
Member
There was a problem hiding this comment.
This will now throw if MaxChunkSize < minBlockCharCount. I don't think it can be, though.
Member
Author
There was a problem hiding this comment.
Append('a', repeatCount: MaxChunkSize + 1) 😦
Member
Author
|
Looks like max < min may be true in some cases and then clamp with throw :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.