This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move debugger attributes to shared partition#15100
Merged
jkotas merged 2 commits intodotnet:masterfrom Nov 19, 2017
Merged
Conversation
Member
jkotas
commented
Nov 19, 2017
jkotas
commented
- Break down DebuggerAttributes.cs into more files, and applied cleanup done in CoreRT
- Moved two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together
This was referenced Nov 19, 2017
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together
jkotas
force-pushed
the
debuggerattributes
branch
from
9bba0a4 to
196b276
Compare
justinvp
reviewed
Nov 19, 2017
|
|
||
| public DebuggerDisplayAttribute(string value) | ||
| { | ||
| if (value == null) |
There was a problem hiding this comment.
Nit: While you're at it, this could be simplified as:
Value = value ?? "";
Member
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
1 similar comment
Member
Author
|
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test please |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Nov 19, 2017
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot <[email protected]>
jkotas
added a commit
to dotnet/corert
that referenced
this pull request
Nov 19, 2017
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot <[email protected]>
jkotas
added a commit
to dotnet/corert
that referenced
this pull request
Nov 19, 2017
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot <[email protected]>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
- Break down DebuggerAttributes.cs into more files, apply cleanup done in CoreRT - Move two outliers (DebuggerStepperBoundaryAttribute, DebuggerVisualizerAttribute) from CoreFX to CoreLib so that all debugger attributes are together Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.