Move (most) Debugger Attributes to shared partition#14651
Move (most) Debugger Attributes to shared partition#14651benaadams wants to merge 1 commit intodotnet:masterfrom
Conversation
benaadams
force-pushed
the
debuggerattribute
branch
from
98b7acc to
928df8d
Compare
| @@ -22,239 +21,6 @@ public sealed class DebuggerStepThroughAttribute : Attribute | |||
| { | |||
| public DebuggerStepThroughAttribute() { } | |||
There was a problem hiding this comment.
I would move all of them, and add [System.Runtime.CompilerServices.DependencyReductionRoot] under #if !PROJECTN ifdef.
There was a problem hiding this comment.
PROJECTN means .NET Native. This DependencyReductionRoot attribute is only used by the (closed source) .NET Native toolchain.
There was a problem hiding this comment.
So #if PROJECTN rather than #if !PROJECTN?
|
Maybe even move the two debugger attributes from https://github.com/dotnet/corefx/tree/master/src/System.Diagnostics.Debug/src/System/Diagnostics back to CoreLib. It does not really make sense to have all debugger attributes in CoreLib, except two that happened to not be used in CoreLib (they are commented out in the CoreLib file right now). |
|
Superseded by #15100 |
3 participants
corert change dotnet/corert#4774