This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Mark Span.Length as non-versionable#13931
Merged
jkotas merged 2 commits intodotnet:masterfrom Sep 13, 2017
Merged
Conversation
This allows inlining Span.Length accross versioning boundaries in R2R images. We are leaking the Span implementation details already because the Span indexer is treated as intrinsic. Marking a few more trivial methods as non-versionable should not do any future harm.
Before this fix, corerun would AV on certain invalid paths e.g.: corerun test.exe\
|
What does it mean to mark a struct as NonVersionable? |
Member
Author
|
It means that precompiled R2R images will have more efficient code for it, but you are promissing that the layout of the structure will never change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @ahsonkhan
(These changes should not be ported to the slow Span.)