This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Un-clang-format GTF_ flags #11700
Merged
Un-clang-format GTF_ flags #11700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, put some under `#ifdef` to indicate their limited use.
Author
|
@briansull PTAL |
briansull
reviewed
May 17, 2017
| #define GTF_ICON_TLS_HDL 0xC0000000 // GT_CNS_INT -- constant is a TLS ref with offset | ||
| #define GTF_ICON_FTN_ADDR 0xD0000000 // GT_CNS_INT -- constant is a function address | ||
| #define GTF_ICON_CIDMID_HDL 0xE0000000 // GT_CNS_INT -- constant is a class or module ID handle | ||
| #define GTF_ICON_BBC_PTR 0xF0000000 // GT_CNS_INT -- constant is a basic block count pointer |
There was a problem hiding this comment.
Thank You, I was just looking at that horrible mess today.
briansull
reviewed
May 17, 2017
| // with operators: the specified node is an unsigned operator | ||
|
|
||
| #define GTF_LATE_ARG \ | ||
| 0x00200000 // the specified node is evaluated to a temp in the arg list, and this temp is added to gtCallLateArgs. |
There was a problem hiding this comment.
This one was the worst, splitting the define value onto the next line ugg.
briansull
approved these changes
May 18, 2017
Member
|
@dotnet-bot please test Tizen armel Cross Release Build |
hqueue
approved these changes
May 19, 2017
Member
hqueue
left a comment
hqueue
left a comment
There was a problem hiding this comment.
Thank you for cleaning up and isolating LEGACY_BACKEND code from ryujit :)
It is not easy to figure out for newcomers.
Author
|
@dotnet-bot test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
GTF_NO_OP_NO.Also, put some under
#ifdefto indicate their limited use.