This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Single-File: Close AppHost stream when reusing extraction#9010
Merged
Anipik merged 1 commit intodotnet:release/3.1from Mar 25, 2020
Merged
[release/3.1] Single-File: Close AppHost stream when reusing extraction#9010Anipik merged 1 commit intodotnet:release/3.1from
Anipik merged 1 commit intodotnet:release/3.1from
Conversation
dotnet/runtime#1260 A single-file app cannot be renamed while running -- an idiom used while updating the app in-place. When running a single-file app, the AppHost reads itself in order to extract the embedded contents. The Apphost must always read its contents in order to read the headers, but doesn't always extract the contents, because previously extracted files are re-used when available. In the case where apphost doesn't extract, currently, the file stream isn't immediately closed on Windows. This prevents the app from being renamed while running. This change fixes the problem by closing the open stream in all cases. Very Low dotnet/runtime#2272
lpereira
approved these changes
Feb 28, 2020
swaroop-sridhar
added
the
Servicing-consider
jeffschwMSFT
approved these changes
Mar 3, 2020
leecow
added
Servicing-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
dotnet/runtime#1260
Customer Scenario
A single-file app cannot be renamed while running -- an idiom used while updating the app in-place.
Problem
When running a single-file app, the AppHost reads itself in order to extract the embedded contents.
The Apphost must always read its contents in order to read the headers, but doesn't always extract the contents, because previously extracted files are re-used when available.
In the case where apphost doesn't extract, currently, the file stream isn't immediately closed on Windows. This prevents the app from being renamed while running.
Solution
This change fixes the problem by closing the open stream in all cases.
Risk
Very Low
Master Branch
dotnet/runtime#2272