Changes to prepare for consolidation #8593
Conversation
… Convert usages of RepoRoot and ProjectDir to either SetupRoot or RepoRoot depending on if they need files that are at the root of the repo or are setup-specific.
…ild.cmd and corehost/build.sh.
…t.Build.Tasks.SharedFramework.Sdk so we don't need to customize them during consolidation.
dagood
left a comment
dagood
left a comment
There was a problem hiding this comment.
Scanned through it again, LGTM. 🎉
|
Looks like I might have missed a spot in the Arcade SDK. I'll put out a PR there to fix the issue. |
|
Actually the SDK version hasn't been updated yet. That should be automatic... I'll update it manually. |
|
Hmm... I submitted a PR to Maestro++ a while ago to enable auto-updates for this SDK. I'll see why that isn't (apparently) working. dotnet/arcade-services#662 |
Co-Authored-By: Davis Goodin <[email protected]>
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for the quick backporting.
|
The renaming of the LICENSE.TXT to LICENSE needs to be revert asap if the Microsoft.NETCore.App assets (package, ...) are hard-linking to this file. cc @dagood @jkoritzinsky |
|
we can keep the LICENSE.TXT name anyway, initially I thought the renaming is necessary for GH to detect the right license but that was wrong. |
|
Yes, the license link on https://www.nuget.org/packages/Microsoft.NETCore.App.Ref/3.0.0 (and probably more) is a 404 now: https://github.com/dotnet/core-setup/blob/master/LICENSE.TXT. I'll put up a PR. |
3 participants
SetupRootMSBuild property to represent the root of the core-setup repo. It will point to the root folder of the core-setup files in the consolidated repo.Directory.Build.props/Directory.Build.targets.