This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Produce mostly empty Microsoft.NETCore.App#5893
Merged
dagood merged 5 commits intodotnet:masterfrom Apr 23, 2019
Merged
Conversation
dagood
requested review from
MichaelSimons,
ericstj,
johnbeisner and
vitek-karas
Package is now empty with a platforms package dependency. Create Microsoft.NETCore.App.Insertion transport package for compatibility workarounds. This commit also moves netcoreapp sfx generation to the new infrastructure to more easily handle the migration away from Microsoft.NETCore.App.
If tests use MNA, use MNAI.
dagood
force-pushed
the
empty-netcoreapp
branch
from
18a970d to
20e14d6
Compare
Member
|
Does this include continuing to produce a package with the existing contents of the Microsoft.NETCore.App package, but with a different package name? |
Member
Author
|
Yep, that's |
It isn't just for insertion into core-sdk, we use it in core-setup too for now.
Member
Author
|
@MichaelSimons @ericstj can you PTAL? @johnbeisner do you have time to handle the break core-sdk-side today? I imagine it's mainly changing references to |
MichaelSimons
approved these changes
Apr 22, 2019
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
LGTM although I have no wix experience 😄
Co-Authored-By: dagood <[email protected]>
Member
Author
|
This missed the Preview 5 snap. @dsplaisted @nguerrera let me know if you think this qualifies as a critical bugfix for Preview 5. From the description of what it's solving, it seems like a QoL change that isn't critical. |
Member
|
No, we did not want to take this for preview 5. From our team's POV, you can merge it as soon as the branch is open for preview 6. |
5 tasks
jkotas
added a commit
to dotnet/coreclr
that referenced
this pull request
Apr 30, 2019
wtgodbe
pushed a commit
to dotnet/coreclr
that referenced
this pull request
May 15, 2019
* Update dependencies from https://github.com/dotnet/core-setup build 20190429.07 - Microsoft.NETCore.App - 3.0.0-preview6-27629-07 * Workaround for dotnet/core-setup#5893 * Update dependencies from https://github.com/dotnet/core-setup build 20190502.01 - Microsoft.NETCore.App - 3.0.0-preview6-27702-01 * Update dependencies from https://github.com/dotnet/core-setup build 20190503.02 - Microsoft.NETCore.App - 3.0.0-preview6-27703-02 * Update dependencies from https://github.com/dotnet/core-setup build 20190503.17 - Microsoft.NETCore.App - 3.0.0-preview6-27703-17 * Update dependencies from https://github.com/dotnet/core-setup build 20190505.02 - Microsoft.NETCore.App - 3.0.0-preview6-27705-02 * Update dependencies from https://github.com/dotnet/core-setup build 20190506.03 - Microsoft.NETCore.App - 3.0.0-preview6-27706-03 * Update dependencies from https://github.com/dotnet/core-setup build 20190506.21 - Microsoft.NETCore.App - 3.0.0-preview6-27706-21 * Update dependencies from https://github.com/dotnet/core-setup build 20190507.10 - Microsoft.NETCore.App - 3.0.0-preview6-27707-10 * Workaround for Microsoft.NetCore.App version in Coreclr.TestWrapper.csproj to unblock #24149 * Update dependencies from https://github.com/dotnet/core-setup build 20190508.04 - Microsoft.NETCore.App - 3.0.0-preview6-27708-04 * Add comment attaching specific pull request to workaround * Update dependencies from https://github.com/dotnet/core-setup build 20190509.05 - Microsoft.NETCore.App - 3.0.0-preview6-27709-05 * Add comments in versions.props to prevent merge conflicts in future blocked maestro PRs * Update dependencies from https://github.com/dotnet/core-setup build 20190514.15 - Microsoft.NETCore.App - 3.0.0-preview6-27714-15
franksinankaya
pushed a commit
to franksinankaya/coreclr
that referenced
this pull request
May 30, 2019
* Update dependencies from https://github.com/dotnet/core-setup build 20190429.07 - Microsoft.NETCore.App - 3.0.0-preview6-27629-07 * Workaround for dotnet/core-setup#5893 * Update dependencies from https://github.com/dotnet/core-setup build 20190502.01 - Microsoft.NETCore.App - 3.0.0-preview6-27702-01 * Update dependencies from https://github.com/dotnet/core-setup build 20190503.02 - Microsoft.NETCore.App - 3.0.0-preview6-27703-02 * Update dependencies from https://github.com/dotnet/core-setup build 20190503.17 - Microsoft.NETCore.App - 3.0.0-preview6-27703-17 * Update dependencies from https://github.com/dotnet/core-setup build 20190505.02 - Microsoft.NETCore.App - 3.0.0-preview6-27705-02 * Update dependencies from https://github.com/dotnet/core-setup build 20190506.03 - Microsoft.NETCore.App - 3.0.0-preview6-27706-03 * Update dependencies from https://github.com/dotnet/core-setup build 20190506.21 - Microsoft.NETCore.App - 3.0.0-preview6-27706-21 * Update dependencies from https://github.com/dotnet/core-setup build 20190507.10 - Microsoft.NETCore.App - 3.0.0-preview6-27707-10 * Workaround for Microsoft.NetCore.App version in Coreclr.TestWrapper.csproj to unblock dotnet#24149 * Update dependencies from https://github.com/dotnet/core-setup build 20190508.04 - Microsoft.NETCore.App - 3.0.0-preview6-27708-04 * Add comment attaching specific pull request to workaround * Update dependencies from https://github.com/dotnet/core-setup build 20190509.05 - Microsoft.NETCore.App - 3.0.0-preview6-27709-05 * Add comments in versions.props to prevent merge conflicts in future blocked maestro PRs * Update dependencies from https://github.com/dotnet/core-setup build 20190514.15 - Microsoft.NETCore.App - 3.0.0-preview6-27714-15
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Produce mostly empty Microsoft.NETCore.App Package is now empty with a platforms package dependency. Create Microsoft.NETCore.App.Insertion transport package for compatibility workarounds. This commit also moves netcoreapp sfx generation to the new infrastructure to more easily handle the migration away from Microsoft.NETCore.App. * Test workarounds for Msft.NETCore.App.Insertion If tests use MNA, use MNAI. * M.NETCore.App.Insertion => M.NETCore.App.Internal It isn't just for insertion into core-sdk, we use it in core-setup too for now. * Update dir.props: quote '/' and '\' in comment Co-Authored-By: dagood <[email protected]> * Comment on explicit .lib exclusion Commit migrated from dotnet/core-setup@0752a17
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…4149) * Update dependencies from https://github.com/dotnet/core-setup build 20190429.07 - Microsoft.NETCore.App - 3.0.0-preview6-27629-07 * Workaround for dotnet/core-setup#5893 * Update dependencies from https://github.com/dotnet/core-setup build 20190502.01 - Microsoft.NETCore.App - 3.0.0-preview6-27702-01 * Update dependencies from https://github.com/dotnet/core-setup build 20190503.02 - Microsoft.NETCore.App - 3.0.0-preview6-27703-02 * Update dependencies from https://github.com/dotnet/core-setup build 20190503.17 - Microsoft.NETCore.App - 3.0.0-preview6-27703-17 * Update dependencies from https://github.com/dotnet/core-setup build 20190505.02 - Microsoft.NETCore.App - 3.0.0-preview6-27705-02 * Update dependencies from https://github.com/dotnet/core-setup build 20190506.03 - Microsoft.NETCore.App - 3.0.0-preview6-27706-03 * Update dependencies from https://github.com/dotnet/core-setup build 20190506.21 - Microsoft.NETCore.App - 3.0.0-preview6-27706-21 * Update dependencies from https://github.com/dotnet/core-setup build 20190507.10 - Microsoft.NETCore.App - 3.0.0-preview6-27707-10 * Workaround for Microsoft.NetCore.App version in Coreclr.TestWrapper.csproj to unblock dotnet/coreclr#24149 * Update dependencies from https://github.com/dotnet/core-setup build 20190508.04 - Microsoft.NETCore.App - 3.0.0-preview6-27708-04 * Add comment attaching specific pull request to workaround * Update dependencies from https://github.com/dotnet/core-setup build 20190509.05 - Microsoft.NETCore.App - 3.0.0-preview6-27709-05 * Add comments in versions.props to prevent merge conflicts in future blocked maestro PRs * Update dependencies from https://github.com/dotnet/core-setup build 20190514.15 - Microsoft.NETCore.App - 3.0.0-preview6-27714-15 Commit migrated from dotnet/coreclr@e03969f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dotnet/core-setup/issues/5663
See commit messages for more details on why this ended up being pretty large.
Manual testing was mostly comparing MSI tables, but also installing them and comparing on-disk (and in-registry) results. I also spot-checked the macOS runtime pkg and Debian/RPM packages.
@johnbeisner let me know when you're ready for this, a hard break is expected.
/cc @nguerrera @dsplaisted