Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates the .NET Core Uninstall Tool installer from WiX Toolset 3 to WiX 5, modernizing the build process by replacing PowerShell-based Heat/Candle/Light commands with the WiX SDK project model.
Key Changes:
- Replaces WiX 3 toolchain with WiX 5 SDK and removes manual tool acquisition
- Updates WXS files to use WiX v4 schema and modernized syntax
- Migrates from PowerShell-driven build to MSBuild-integrated .wixproj
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Adds WiX 5 SDK reference |
| eng/Versions.props | Defines WiX 5 and Build.Tasks.Installers package versions |
| eng/Version.Details.xml | Tracks Build.Tasks.Installers dependency |
| src/redist/redist.csproj | Updates to use centralized package version and adds wixproj P2P reference |
| src/redist/targets/GenerateMSIs.targets | Removes WiX 3 acquisition and replaces PowerShell script with MSBuild invocation |
| src/redist/targets/packaging/windows/dotnetCoreUninstall/uninstall-tool.wixproj | New WiX SDK project file replacing PowerShell script |
| src/redist/targets/packaging/windows/dotnetCoreUninstall/variables.wxi | Updates platform variable references from Platform to InstallerPlatform |
| src/redist/targets/packaging/windows/dotnetCoreUninstall/provider.wxs | Updates to WiX v4 schema and modern Provides syntax |
| src/redist/targets/packaging/windows/dotnetCoreUninstall/dotnet.wxs | Converts from Product/Package to Package-only, updates to v4 schema, modernizes UI Publish elements |
| src/redist/targets/packaging/windows/dotnetCoreUninstall/generatemsi.ps1 | Deleted PowerShell script no longer needed with WiX SDK |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joeloff
reviewed
Dec 18, 2025
|
|
||
| <Target Name="SetInstallerInfo" BeforeTargets="CoreCompile"> | ||
| <PropertyGroup> | ||
| <!-- Templates support rebuilding the same project for multiple MSIs so we expect some properties to be passed to this project when building. --> |
Member
There was a problem hiding this comment.
Can probably remove this comment. That applies to the SDK template installs.
joeloff
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the uninstall tool to Wix 5.
I've followed the guidance and also used the recent SDK migration, as a model.