Update dependencies and workaround dotnet/sdk#2976 #7844

natemcmaster · 2019-02-22T05:01:51Z

Opened manually using our script that finds coherent dependencies

benaadams · 2019-02-22T05:30:52Z

Components/Blazor/Blazor/test/Hosting/WebAssemblyHostTest.cs(65,63):
 error CS0117: 'JSRuntime' does not contain a definition for 'Current'
 [/home/vsts/work/1/s/src/Components/Blazor/Blazor/test/Microsoft.AspNetCore.Blazor.Tests.csproj]
Components/Blazor/testassets/Microsoft.AspNetCore.Blazor.E2EPerformance/BenchmarkEvent.cs(12,45):
 error CS0117: 'JSRuntime' does not contain a definition for 'Current' [/home/vsts/work/1/s/src/Components/Blazor/testassets/Microsoft.AspNetCore.Blazor.E2EPerformance/Microsoft.AspNetCore.Blazor.E2EPerformance.csproj]

natemcmaster · 2019-02-22T05:38:43Z

@pranavkm handing the mic to you. Can you update this repo to react to dotnet/extensions#1118?

cc @rynowak @SteveSandersonMS

pranavkm · 2019-02-22T07:13:13Z

/azp run AspNetCore-ci

azure-pipelines · 2019-02-22T07:13:30Z

Azure Pipelines successfully started running 1 pipeline(s).

benaadams · 2019-02-22T14:10:28Z

Back to LoggerFactory being disposed (368 Failed tests)

 System.ObjectDisposedException: Cannot access a disposed object.
  Object name: 'LoggerFactory'.
     at Microsoft.Extensions.Logging.LoggerFactory.CreateLogger(String categoryName)
     at Microsoft.EntityFrameworkCore.Internal.ExternalLoggerFactory.CreateLogger(String categoryName)
     at Microsoft.EntityFrameworkCore.Internal.DiagnosticsLogger`1..ctor(ILoggerFactory loggerFactory, ILoggingOptions loggingOptions, DiagnosticSource diagnosticSource)
     at ResolveService(ILEmitResolverBuilderRuntimeContext , ServiceProviderEngineScope )
     at ResolveService(ILEmitResolverBuilderRuntimeContext , ServiceProviderEngineScope )
     at ResolveService(ILEmitResolverBuilderRuntimeContext , ServiceProviderEngineScope )
     at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
     at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
     at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
     at Microsoft.EntityFrameworkCore.DbContext.get_InternalServiceProvider()
     at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
     at Microsoft.EntityFrameworkCore.DbContext.Set[TEntity]()
     at Microsoft.AspNetCore.Identity.EntityFrameworkCore.UserStore`9.get_UsersSet() in /_/src/Identity/EntityFrameworkCore/src/UserStore.cs:line 128
     at Microsoft.AspNetCore.Identity.EntityFrameworkCore.UserStore`9.get_Users() in /_/src/Identity/EntityFrameworkCore/src/UserStore.cs:line 262
     at Microsoft.AspNetCore.Identity.EntityFrameworkCore.UserStore`9.FindByNameAsync(String normalizedUserName, CancellationToken cancellationToken) in /_/src/Identity/EntityFrameworkCore/src/UserStore.cs:line 254
     at Microsoft.AspNetCore.Identity.UserManager`1.FindByNameAsync(String userName) in /_/src/Identity/Extensions.Core/src/UserManager.cs:line 573
     at Microsoft.AspNetCore.Identity.UserValidator`1.ValidateUserName(UserManager`1 manager, TUser user, ICollection`1 errors) in /_/src/Identity/Extensions.Core/src/UserValidator.cs:line 79
     at Microsoft.AspNetCore.Identity.UserValidator`1.ValidateAsync(UserManager`1 manager, TUser user) in /_/src/Identity/Extensions.Core/src/UserValidator.cs:line 56
     at Microsoft.AspNetCore.Identity.UserManager`1.ValidateUserAsync(TUser user) in /_/src/Identity/Extensions.Core/src/UserManager.cs:line 2494
     at Microsoft.AspNetCore.Identity.UserManager`1.CreateAsync(TUser user) in /_/src/Identity/Extensions.Core/src/UserManager.cs:line 470
     at Microsoft.AspNetCore.Identity.UserManager`1.CreateAsync(TUser user, String password) in /_/src/Identity/Extensions.Core/src/UserManager.cs:line 602
     at Microsoft.AspNetCore.Identity.UI.V3.Pages.Account.Internal.RegisterModel`1.OnPostAsync(String returnUrl) in /_/src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Register.cshtml.cs:line 125
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.ExecutorFactory.GenericTaskHandlerMethod.Convert[T](Object taskAsObject) in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/ExecutorFactory.cs:line 145
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.ExecutorFactory.GenericTaskHandlerMethod.Execute(Object receiver, Object[] arguments) in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/ExecutorFactory.cs:line 139
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.InvokeHandlerMethodAsync() in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvoker.cs:line 288
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.InvokeNextPageFilterAsync() in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvoker.cs:line 654
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.Rethrow(PageHandlerExecutedContext context) in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvoker.cs:line 696
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted) in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvoker.cs:line 628
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.InvokeInnerFilterAsync() in /_/src/Mvc/Mvc.RazorPages/src/Infrastructure/PageActionInvoker.cs:line 93
     at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeNextResourceFilter() in /_/src/Mvc/Mvc.Core/src/Infrastructure/ResourceInvoker.cs:line 809
     at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContext context) in /_/src/Mvc/Mvc.Core/src/Infrastructure/ResourceInvoker.cs:line 1153
     at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted) in /_/src/Mvc/Mvc.Core/src/Infrastructure/ResourceInvoker.cs:line 762
     at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync() in /_/src/Mvc/Mvc.Core/src/Infrastructure/ResourceInvoker.cs:line 129
     at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeAsync() in /_/src/Mvc/Mvc.Core/src/Infrastructure/ResourceInvoker.cs:line 101
     at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext) in /_/src/Http/Routing/src/EndpointMiddleware.cs:line 53
     at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.Invoke(HttpContext httpContext) in /_/src/Http/Routing/src/EndpointRoutingMiddleware.cs:line 79
     at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context) in /_/src/Security/Authentication/Core/src/AuthenticationMiddleware.cs:line 62

Could "Make ILoggerFactory a scoped service" dotnet/efcore#14706 have caused the disposal? /cc @ajcvickers

e.g.

-  { typeof(ILoggerFactory), new ServiceCharacteristics(ServiceLifetime.Singleton) },
+  { typeof(ILoggerFactory), new ServiceCharacteristics(ServiceLifetime.Scoped) },

Or perhaps

- services.AddSingleton(loggerFactory);
+ services.AddScoped<ILoggerFactory>(_ => new ExternalLoggerFactory(loggerFactory));

Perhaps is causing both ILoggerFactory's to get disposed? dotnet/extensions#1155 (or maybe there is only the scoped one and its used out of scope?)

benaadams · 2019-02-22T14:59:25Z

Most of the 368 failed tests tests are under Microsoft.AspNetCore.Identity.FunctionalTests

Couple in Microsoft.Extensions.Diagnostics.HealthChecks.DbContextHealthCheckTest which seem different

ajcvickers · 2019-02-22T17:39:48Z

In have a PR out to fix EF: dotnet/efcore#14783

dougbu

Once we have the newer EF Core and the builds turn green

dougbu · 2019-02-22T05:59:21Z

eng/Version.Details.xml

    </Dependency>
-    <Dependency Name="Microsoft.AspNetCore.Testing" Version="3.0.0-preview3.19115.4">
+    <Dependency Name="Microsoft.AspNetCore.Testing" Version="3.0.0-preview3.19120.1">


Strange that this update doesn't cause restore failures (version downgrade errors) -- as is happening in AspNetCore-Tooling. Recent versions of this package depend on newer Xunit versions than in this repo. 2.4.0 is the magic number.

This repo is already using xunit 2.4.0. I think aspnetcore-tooling was the only one still on 2.3

natemcmaster · 2019-02-22T22:49:12Z

Pushed a change to react to dotnet/razor#240, dotnet/efcore#14790, and dotnet/extensions#1159

build/sources.props

benaadams · 2019-02-22T23:30:49Z

Not sure it has the new EF stuff yet?

       An unhandled exception has occurred while executing the request.
  System.ObjectDisposedException: Cannot access a disposed object.
  Object name: 'LoggerFactory'.
     at Microsoft.Extensions.Logging.LoggerFactory.CreateLogger(String categoryName)
     at Microsoft.EntityFrameworkCore.Internal.ExternalLoggerFactory.CreateLogger(String categoryName)
     at Microsoft.EntityFrameworkCore.Internal.DiagnosticsLogger`1..ctor(ILoggerFactory loggerFactory, ILoggingOptions loggingOptions, DiagnosticSource diagnosticSource)
     at ResolveService(ILEmitResolverBuilderRuntimeContext , ServiceProviderEngineScope )
     at ResolveService(ILEmitResolverBuilderRuntimeContext , ServiceProviderEngineScope )
     at ResolveService(ILEmitResolverBuilderRuntimeContext , ServiceProviderEngineScope )
     at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
     at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
     at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
     at Microsoft.EntityFrameworkCore.DbContext.get_InternalServiceProvider()
     at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
     at Microsoft.EntityFrameworkCore.DbContext.Set[TEntity]()

dougbu · 2019-02-22T23:38:57Z

@benaadams no it doesn't. @natemcmaster could you rerun your tool please?

…net/aspnet-aspnetcore/index.json

natemcmaster · 2019-02-23T00:01:50Z

Updated with latest EFCore. 🤞

benaadams · 2019-02-23T00:11:40Z

MVC using its own obsolete method?

/home/vsts/work/1/s/src/Mvc/Mvc.Localization/src/HtmlLocalizer.cs(95,38):

 error CS0618: 'IStringLocalizer.WithCulture(CultureInfo)' is obsolete:
 'This method is obsolete. Use `CurrentCulture` and `CurrentUICulture` instead.' 
[/home/vsts/work/1/s/src/Mvc/Mvc.Localization/src/Microsoft.AspNetCore.Mvc.Localization.csproj]

natemcmaster · 2019-02-23T00:23:08Z

@ryanbrandenburg can you update AspNetCore to react to change you made in Extensions?

benaadams · 2019-02-23T01:31:40Z

Restart Build Linux x64; was a docker registry timeout

Step 1/12 : FROM microsoft/dotnet:2.1-runtime-deps-bionic
Get https://registry-1.docker.io/v2/: net/http: TLS handshake timeout
##[error]Bash exited with code '1'.

benaadams · 2019-02-23T01:37:26Z

macOs failure

Microsoft.Extensions.Diagnostics.HealthChecks.DbContextHealthCheckTest.CheckAsync_CustomTest_Unhealthy
Assert.Equal() Failure
Expected: Unhealthy
Actual: Healthy

Stack trace
   at Microsoft.Extensions.Diagnostics.HealthChecks.DbContextHealthCheckTest.CheckAsync_CustomTest_Unhealthy() in /_/src/Middleware/HealthChecks.EntityFrameworkCore/test/DbContextHealthCheckTest.cs:line 103
--- End of stack trace from previous location where exception was thrown ---

natemcmaster · 2019-02-23T01:42:12Z

Getting closer. The ILoggerFactory test failures and compiler errors are gone.

Next failure:

  Failed   Microsoft.Extensions.Diagnostics.HealthChecks.DbContextHealthCheckTest.CheckAsync_CustomTest_Unhealthy
  Error Message:
   Assert.Equal() Failure
  Expected: Unhealthy
  Actual:   Healthy

@Tratcher @rynowak any ideas?

ajcvickers · 2019-02-23T01:45:59Z

@natemcmaster @Tratcher @rynowak I don't have time to investigate right now, but ping me if the DbContextHealthCheck looks like it is caused by EF changes.

natemcmaster · 2019-02-23T01:48:16Z

There's a more than good chance the failure is due to EFCore. The health checks stuff hasn't changed recently. I'll take a look at the test to see if the test makes bad assumptions about EFCore and service scopes.

natemcmaster · 2019-02-23T01:58:51Z

@ajcvickers it looks like the in-memory database used in this test returns different results.

Before EFCore update:

After EFCore update:

Test code: https://github.com/aspnet/AspNetCore/blob/90e893ed077b82168354b6563f40bebad398ed77/src/Middleware/HealthChecks.EntityFrameworkCore/test/DbContextHealthCheckTest.cs#L85-L117

natemcmaster · 2019-02-23T02:02:32Z

@ajcvickers @rynowak - workaround for changes in EF in-memory database behavior:

aaaecbf

rynowak · 2019-02-23T02:03:20Z

Looks fine, a comment would make it mo better.

ajcvickers · 2019-02-23T19:19:17Z

@natemcmaster @rynowak Thanks Nate. Here's what's happening. When an in-memory database with a specific name is used, that database is under normal circumstances supposed to be the same database later if the same name is used. However, in reality the named database is rooted by default in EF's internal service provider. So the above behavior holds true as long as the same internal service provider is used by EF, which for a given EF configuration should be true.

So this behavior that is now being seen in these tests--when a database called "Test" is used it is shared by all tests that create a database with that name. This is as things are supposed to be, and is one of the things that the EF breaking change makes "better". (The reason for this is that previously anytime a new ILoggerFactory was used with each DbContext instance, it caused EF to build a new internal service provider for that DbContext instance. (This is easy to hit in ASP.NET tests that often create a new ILoggerFactory for each test.) This no longer happens, so all the tests use the same EF internal service provider, which means they get to share the in-memory database.)

In this case, the tests were dependent on the old behavior. So this is a case where the breaking change really broke things, but in an expected way, and with ultimately better, more consistent behavior. Still we should make sure it's documented. /cc @divega

Update dependencies and workaround dotnet/sdk#2976

6b13b30

natemcmaster requested a review from dougbu as a code owner February 22, 2019 05:01

natemcmaster assigned pranavkm Feb 22, 2019

pranavkm mentioned this pull request Feb 22, 2019

Remove more references to JSRuntime.Current #7846

Merged

natemcmaster assigned ajcvickers and unassigned pranavkm Feb 22, 2019

natemcmaster added blocked The work on this issue is blocked due to some dependency area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Feb 22, 2019

dougbu reviewed Feb 22, 2019

View reviewed changes

natemcmaster mentioned this pull request Feb 22, 2019

[master] Update dependencies from aspnet/AspNetCore-Tooling #7683

Closed

Add new restore sources

35ccb50

natemcmaster force-pushed the namc/update branch from 54c22ea to 35ccb50 Compare February 22, 2019 22:50

dougbu approved these changes Feb 22, 2019

View reviewed changes

build/sources.props Show resolved Hide resolved

Nate McMaster added 3 commits February 22, 2019 16:00

Update BAR manifest to point to https://dotnetfeed.blob.core.windows.…

34b6756

…net/aspnet-aspnetcore/index.json

Update dependencies

ae82582

Merge branch 'release/3.0-preview3' into namc/update

e91c291

Merge branch 'release/3.0-preview3' into namc/update

f7e202f

natemcmaster assigned ryanbrandenburg Feb 23, 2019

natemcmaster and others added 2 commits February 22, 2019 16:29

Update ci.yml

4972e3b

Obsolete WithCulture

3e2cf46

dougbu approved these changes Feb 23, 2019

View reviewed changes

natemcmaster assigned rynowak and unassigned ajcvickers and ryanbrandenburg Feb 23, 2019

Add retries to dockerbuild.sh

f4cb17a

Ensure each test run gets a unique in-memory database

aaaecbf

natemcmaster requested a review from Tratcher as a code owner February 23, 2019 02:01

natemcmaster unassigned rynowak Feb 23, 2019

mo-better comments

7e98997

natemcmaster removed the blocked The work on this issue is blocked due to some dependency label Feb 23, 2019

natemcmaster merged commit 1b27c99 into release/3.0-preview3 Feb 23, 2019

natemcmaster deleted the namc/update branch February 23, 2019 03:09

snyk-bot mentioned this pull request Mar 9, 2020

[Snyk] Security upgrade react-scripts from 3.1.0 to 3.3.0 SeppPenner/AspNetCore#3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies and workaround dotnet/sdk#2976 #7844

Update dependencies and workaround dotnet/sdk#2976 #7844

natemcmaster commented Feb 22, 2019

benaadams commented Feb 22, 2019

natemcmaster commented Feb 22, 2019

pranavkm commented Feb 22, 2019

azure-pipelines bot commented Feb 22, 2019

benaadams commented Feb 22, 2019 •

edited

Loading

benaadams commented Feb 22, 2019

ajcvickers commented Feb 22, 2019

dougbu left a comment

dougbu Feb 22, 2019

natemcmaster Feb 22, 2019

natemcmaster commented Feb 22, 2019

benaadams commented Feb 22, 2019

dougbu commented Feb 22, 2019

natemcmaster commented Feb 23, 2019

benaadams commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

benaadams commented Feb 23, 2019

benaadams commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

ajcvickers commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

rynowak commented Feb 23, 2019

ajcvickers commented Feb 23, 2019

Update dependencies and workaround dotnet/sdk#2976 #7844

Update dependencies and workaround dotnet/sdk#2976 #7844

Conversation

natemcmaster commented Feb 22, 2019

benaadams commented Feb 22, 2019

natemcmaster commented Feb 22, 2019

pranavkm commented Feb 22, 2019

azure-pipelines bot commented Feb 22, 2019

benaadams commented Feb 22, 2019 • edited Loading

benaadams commented Feb 22, 2019

ajcvickers commented Feb 22, 2019

dougbu left a comment

Choose a reason for hiding this comment

dougbu Feb 22, 2019

Choose a reason for hiding this comment

natemcmaster Feb 22, 2019

Choose a reason for hiding this comment

natemcmaster commented Feb 22, 2019

benaadams commented Feb 22, 2019

dougbu commented Feb 22, 2019

natemcmaster commented Feb 23, 2019

benaadams commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

benaadams commented Feb 23, 2019

benaadams commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

ajcvickers commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

natemcmaster commented Feb 23, 2019

rynowak commented Feb 23, 2019

ajcvickers commented Feb 23, 2019

benaadams commented Feb 22, 2019 •

edited

Loading