Repository navigation
[ci] Use CoreCLR for WebAssembly trimming checks - #69642
Conversation
Co-authored-by: Copilot <[email protected]> Copilot-Session: 9170c669-e132-46bb-8258-e448425535d6
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
CoreCLR runtime-pack resolution and successful execution of the existing trimming checks remain unverified.
Review effort: Balanced
Findings: None
What changed in this PR
Switches the WasmLinkerTest test asset to CoreCLR for WebAssembly trimming checks, supporting dotnet/runtime#134397.
Changes:
- Sets
UseMonoRuntimetofalse, leaving the existing trimming configuration unchanged.
| File | Description |
|---|---|
| src/Components/WebAssembly/testassets/WasmLinkerTest/WasmLinkerTest.csproj | Selects CoreCLR instead of Mono. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
Verified build 1620906 for this revision: Test: Ubuntu x64 → Run build.sh executed WasmLinkerTest’s ILLinkTrimWasmProjects target and ILLink task successfully. The binlog confirms ILLink referenced Microsoft.NETCore.App.Runtime.browser-wasm 12.0.0-alpha.1.26473.114 (CoreCLR) and used the wasm-linked output directory.
Description
This PR switches
WasmLinkerTestto the CoreCLR runtime pack and keeps the existing trimming coverage.Contributes to dotnet/runtime#134397.
Note
Prepared with GitHub Copilot.