Improvements to testing in Codespaces#65019
Merged
akoeplinger merged 1 commit intomainfrom Jan 13, 2026
Merged
Conversation
1. Playwright needs to disable the chromium sandbox as it doesn't work in the container 2. Need to pass --disable-dev-shm-usage to Selenium as /dev/shm is too small in the container 3. Other random fixes
akoeplinger
added
the
area-infrastructure
akoeplinger
requested review from
BrennanConroy,
JamesNK and
halter73
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves testing support in container environments, particularly Codespaces, by addressing browser automation issues specific to containerized execution.
Changes:
- Disables Chromium sandbox in Playwright for container environments where sandboxing doesn't work
- Adds
--disable-dev-shm-usageflag to Selenium Chrome options to work around limited/dev/shmsize in containers - Fixes platform-specific issues including Windows-only API calls and IPv6/IPv4 any-address URL handling
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Testing/src/HelixHelper.cs | Returns empty string instead of null from GetTargetHelixQueue() for improved null safety |
| src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.TrimmingTests/TestTypedClients.cs | Replaces IPv6/IPv4 any-addresses with localhost in server URLs for client connections |
| src/Shared/E2ETesting/BrowserFixture.cs | Adds --disable-dev-shm-usage argument to Chrome options for container compatibility |
| src/Shared/BrowserTesting/src/BrowserTestBase.cs | Detects container environments and loads container-specific Playwright settings |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/Infrastructure/SkipIfNotAdminAttribute.cs | Adds Windows OS check before accessing Windows-specific APIs to prevent crashes on non-Windows platforms |
| src/ProjectTemplates/test/Templates.Blazor.Tests/playwrightSettings.container.json | Adds new Playwright configuration file that disables Chromium sandbox for container environments |
ilonatommy
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.