-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix templatestrings in RazorClassLibrary template #64796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When building locally these files get modified with the new keys. Looks like this was caused by #64532
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the RazorClassLibrary template localization files that were being modified during local builds after PR #64532. The changes update the post-action keys to align with the template.json configuration by renaming openInEditor to openPageInEditor and adding a new openComponentInEditor action.
Key Changes:
- Renames the
postActions/openInEditor/descriptionkey topostActions/openPageInEditor/descriptionacross all localization files - Adds a new
postActions/openComponentInEditor/descriptionkey for opening Razor components in the editor - Updates all 13 language-specific localization files (cs, de, en, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| templatestrings.zh-Hant.json | Renames openInEditor key and adds openComponentInEditor for Traditional Chinese localization |
| templatestrings.zh-Hans.json | Renames openInEditor key and adds openComponentInEditor for Simplified Chinese localization |
| templatestrings.tr.json | Renames openInEditor key and adds openComponentInEditor for Turkish localization |
| templatestrings.ru.json | Renames openInEditor key and adds openComponentInEditor for Russian localization |
| templatestrings.pt-BR.json | Renames openInEditor key and adds openComponentInEditor for Brazilian Portuguese localization |
| templatestrings.pl.json | Renames openInEditor key and adds openComponentInEditor for Polish localization |
| templatestrings.ko.json | Renames openInEditor key and adds openComponentInEditor for Korean localization |
| templatestrings.ja.json | Renames openInEditor key and adds openComponentInEditor for Japanese localization |
| templatestrings.it.json | Renames openInEditor key and adds openComponentInEditor for Italian localization |
| templatestrings.fr.json | Renames openInEditor key and adds openComponentInEditor for French localization |
| templatestrings.es.json | Renames openInEditor key and adds openComponentInEditor for Spanish localization |
| templatestrings.en.json | Renames openInEditor key and adds openComponentInEditor for English localization |
| templatestrings.de.json | Renames openInEditor key and adds openComponentInEditor for German localization |
| templatestrings.cs.json | Renames openInEditor key and adds openComponentInEditor for Czech localization |
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.ru.json
Show resolved
Hide resolved
...plates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.pt-BR.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.pl.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.ko.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.ja.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.tr.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.es.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.de.json
Show resolved
Hide resolved
...Templates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.cs.json
Show resolved
Hide resolved
...ates/content/RazorClassLibrary-CSharp/.template.config/localize/templatestrings.zh-Hant.json
Show resolved
Hide resolved
drewnoakes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
When building locally these files get modified with the new keys. Looks like this was caused by #64532