Skip to content

Resolve concurrency with test stub to resolve #49745. #63299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrennanConroy merged 1 commit into from
Dec 10, 2025
Merged

Resolve concurrency with test stub to resolve #49745. #63299

BrennanConroy merged 1 commit into from
Dec 10, 2025

Conversation

@feherzsolt
Copy link
Contributor

@feherzsolt feherzsolt commented Aug 17, 2025 •
edited by BrennanConroy
Loading

Eliminate concurrentcy with test stub

  • [x ] You've read the Contributor Guide and Code of Conduct.
  • [x ] You've included unit or integration tests for your change, where applicable.
  • [x ] You've included inline docs for your change, where applicable.
  • [x ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

TestPublisher was using a List which was modified from multiple concurrent Task which might have led to test flakiness. I have replaced the collection with a thread safe one to try resolving this flakiness.

(Hopefully fixes)
#49745

@github-actions github-actions bot added the area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) label Aug 17, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 17, 2025
@feherzsolt feherzsolt mentioned this pull request Aug 18, 2025
Open
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Aug 24, 2025
@build-analysis build-analysis bot mentioned this pull request Aug 26, 2025
Open
@BrennanConroy
Copy link
Member

BrennanConroy commented Dec 10, 2025

/azp run

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 10, 2025
@azure-pipelines
Copy link

azure-pipelines bot commented Dec 10, 2025

Azure Pipelines successfully started running 2 pipeline(s).

@BrennanConroy BrennanConroy enabled auto-merge (squash) December 10, 2025 21:27
@build-analysis build-analysis bot mentioned this pull request Dec 10, 2025
Open
@BrennanConroy BrennanConroy merged commit c9d0750 into dotnet:main Dec 10, 2025
29 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Dec 10, 2025
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

Assignees

No one assigned

Labels

area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

11.0-preview1

Development

Successfully merging this pull request may close these issues.

2 participants

@feherzsolt @BrennanConroy