Fix race in RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted#57450
Merged
amcasey merged 2 commits intodotnet:mainfrom Aug 23, 2024
Merged
Fix race in RST_STREAM_IncompleteRequest_AdditionalWindowUpdateFrame_ConnectionAborted#57450amcasey merged 2 commits intodotnet:mainfrom
amcasey merged 2 commits intodotnet:mainfrom
Conversation
…_ConnectionAborted There was a race between early-sending the response headers and sending the goaway for the aborted connection. Fixes dotnet#53744
amcasey
requested review from
BrennanConroy,
JamesNK,
halter73 and
mgravell
as code owners
ghost
added
the
area-networking
JamesNK
reviewed
Aug 22, 2024
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
Show resolved
Hide resolved
amcasey
commented
Aug 22, 2024
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs
Show resolved
Hide resolved
amcasey
changed the title
Member
Author
|
@JamesNK This one too? 🙏 |
JamesNK
approved these changes
Aug 23, 2024
adityamandaleeka
added a commit
to adityamandaleeka/aspnetcore
that referenced
this pull request
Feb 17, 2026
Move tcs.TrySetResult() after WaitForConnectionErrorAsync to prevent the response HEADERS from racing with the GOAWAY frame. Same fix pattern as dotnet#57450 applied to AdditionalDataFrames and AdditionalTrailerFrames variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a race between early-sending the response headers and sending the goaway for the aborted connection.
For #53744