HybridCache - fix RemoveKeyAsync incorrectly calling RemoveByTagAsync #56719
+87
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
mgravell
added a commit
to mgravell/runtime
that referenced
this pull request
Jul 10, 2024
mgravell
added a commit
to mgravell/runtime
that referenced
this pull request
Jul 10, 2024
BrennanConroy
approved these changes
Jul 10, 2024
jozkee
added a commit
to dotnet/runtime
that referenced
this pull request
Jul 22, 2024
…103103) * HybridCache migration from aspnet * use cancellationToken instead of token * reapply dotnet/aspnetcore#56719 * Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/HybridCache.cs Co-authored-by: David Cantú <[email protected]> * Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/HybridCache.cs Co-authored-by: David Cantú <[email protected]> * Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/HybridCache.cs Co-authored-by: David Cantú <[email protected]> * prefer throw null * use IEnumerable<string> instead of IReadOnlyCollection<string> * remove suppressions * Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/IHybridCacheSerializer.cs Co-authored-by: Stephen Toub <[email protected]> * Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/HybridCacheEntryOptions.cs Co-authored-by: Stephen Toub <[email protected]> * Update src/libraries/Microsoft.Extensions.Caching.Abstractions/src/Hybrid/HybridCacheEntryOptions.cs Co-authored-by: Stephen Toub <[email protected]> * PR nits --------- Co-authored-by: David Cantú <[email protected]> Co-authored-by: Stephen Toub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async voidtests (probably auto-IDE)Fixes #56581