Skip to content

Fix ProjectTemplate build steps with new JDK #56199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sebastienros wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix ProjectTemplate build steps with new JDK #56199

sebastienros wants to merge 9 commits into from

Conversation

@sebastienros
Copy link
Member

@sebastienros sebastienros commented Jun 12, 2024

Fixes #55975

  1. By running this step only on CI the ProjectTemplates local build doesn't work with a missing artifacts\obj\Npm.Workspace\Release\packagesToPack.json file.
  2. Bump gradle because teh current version is not compatible with JDK 22
  3. Reacted to gradle breaking changes: new maven plugin and DSL changes

After these changes eng\build.cmd -all -pack -configuration Release works on my machine.

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Jun 12, 2024
@sebastienros sebastienros changed the title Run pack-workspace.mjs locally Fix ProjectTemplate build steps with new JDK Jun 12, 2024
@sebastienros sebastienros force-pushed the sebros/templatesbuild branch from 84a8831 to 8305762 Compare June 12, 2024 02:01
sebastienros
sebastienros commented Jun 12, 2024
View reviewed changes
src/Framework/App.Ref/src/CompatibilitySuppressions.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
Copy link
Member Author

@sebastienros sebastienros Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept this because building the project keeps changing it back

sebastienros
sebastienros commented Jun 12, 2024
View reviewed changes
src/SignalR/clients/java/signalr/build.gradle Outdated
version project.findProperty('packageVersion') ?: "99.99.99-dev"

sourceCompatibility = 1.8
sourceCompatibility = 9
Copy link
Member Author

@sebastienros sebastienros Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got warnings without that

src/SignalR/clients/java/signalr/core/build.gradle
}
}

createPackage.dependsOn 'generatePomFileForMavenJavaPublication'
Copy link
Member Author

@sebastienros sebastienros Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the internal task that needs to be invoked to trigger publishing

@sebastienros
Copy link
Member Author

sebastienros commented Jun 12, 2024 •
edited
Loading

IT's very probable I forgot something, didn't know what gradle was before this PR. At least I checked that the expected assets were generated:

image

The pom file:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.microsoft.signalr</groupId>
  <artifactId>signalr</artifactId>
  <version>9.0.0-dev</version>
  <packaging>pom</packaging>
  <name>com.microsoft.signalr:signalr</name>
  <description>ASP.NET Core SignalR Client for Java applications</description>
  <url>https://github.com/dotnet/aspnetcore</url>
  <inceptionYear>2018</inceptionYear>
  <licenses>
    <license>
      <name>MIT License</name>
      <url>https://opensource.org/licenses/MIT</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>microsoft</id>
      <name>Microsoft</name>
    </developer>
  </developers>
  <scm>
    <connection>scm:git:https://github.com/dotnet/aspnetcore.git</connection>
    <developerConnection>scm:git:https://github.com/dotnet/aspnetcore.git</developerConnection>
    <url>https://github.com/dotnet/aspnetcore/tree/main</url>
  </scm>
</project>

@sebastienros
Copy link
Member Author

sebastienros commented Jun 12, 2024

Does the CI test the packages and their dependencies? The DSL wrt these dependencies has changed (compile, runtime, test) and I wonder if the final packages have the correct dependencies after this PR, and not too many (like test-only dependencies).

@build-analysis build-analysis bot mentioned this pull request Jun 13, 2024
Closed
3 tasks
@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Jun 18, 2024

Thanks @sebastienros!

@sebastienros
Copy link
Member Author

sebastienros commented Jun 18, 2024

This is blocked on dotnet/dnceng#3093
The CI doesn't pass on macOS and linux because the JDK is too old and the opposite problem happens, which is they don't support the new Graddle.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 26, 2024
@javiercn javiercn requested a review from MackinnonBuck July 5, 2024 11:15
@sebastienros
Copy link
Member Author

sebastienros commented Jul 8, 2024

/azp run

@dotnet-policy-service dotnet-policy-service bot removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 8, 2024
@azure-pipelines
Copy link

azure-pipelines bot commented Jul 8, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jul 16, 2024

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 16, 2024
@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Sep 9, 2024

@sebastienros is this still blocked? If so, can you please update the milestone of the associated issue so that it isn't sitting in an old milestone?

@sebastienros sebastienros mentioned this pull request Jan 9, 2025
Closed
@javiercn
Copy link
Member

javiercn commented Aug 26, 2025

@sebastienros is this still relevant?

@javiercn javiercn removed their assignment Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn approved these changes

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-signalr Includes: SignalR clients and servers pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ProjectTemplates instructions error

5 participants

@sebastienros @mkArtakMSFT @javiercn @MackinnonBuck