Fix static analysis HRESULT / bool conversion warnings#54988
Merged
adityamandaleeka merged 1 commit intodotnet:mainfrom Apr 6, 2024
Merged
Fix static analysis HRESULT / bool conversion warnings#54988adityamandaleeka merged 1 commit intodotnet:mainfrom
adityamandaleeka merged 1 commit intodotnet:mainfrom
Conversation
GrabYourPitchforks
requested review from
BrennanConroy,
JamesNK,
halter73 and
mgravell
as code owners
ghost
added
the
area-networking
adityamandaleeka
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LOG_IF_FAILEDmacro takes anHRESULTinput and returns anHRESULT. It shouldn't be used in anifstatement to detect failure: use theFAILED_LOGmacro instead. Additionally, it shouldn't be passed aBOOL: use theLOG_LAST_ERROR_IFmacro instead (and invert the condition if needed).This follows the pattern for other uses of the
FAILED_LOGandLOG_LAST_ERROR_IFmacros throughout the project. See e.g.:aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/CommonLib/WebConfigConfigurationSection.cpp
Lines 12 to 15 in 649d2cf
aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationinfo.cpp
Line 190 in 649d2cf
Resolves two cpp/hresult-boolean-conversion CodeQL warnings we're seeing on our backend.