Skip to content

Update dependencies from https://github.com/dotnet/runtime build 20240301.1 #54297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eerhardt merged 6 commits into from
Mar 2, 2024
Merged

Update dependencies from https://github.com/dotnet/runtime build 20240301.1 #54297

eerhardt merged 6 commits into from
Mar 2, 2024

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Mar 1, 2024

Split from #54055 to take just the runtime changes.

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
From Version 9.0.0-preview.2.24114.1 -> To Version 9.0.0-preview.3.24151.1

@dotnet-maestro @eerhardt
Update dependencies from https://github.com/dotnet/runtime build 2024…
713cdf9 
…0301.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-preview.2.24114.1 -> To Version 9.0.0-preview.3.24151.1
@eerhardt eerhardt requested review from a team and wtgodbe as code owners March 1, 2024 18:04
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 1, 2024
@eerhardt eerhardt mentioned this pull request Mar 1, 2024
Merged
@eerhardt
Copy link
Member Author

eerhardt commented Mar 1, 2024

@javiercn @mkArtakMSFT @MackinnonBuck - the components e2e tests are consistently failing with this update.

Assert.Equal() Failure
          ↓ (pos 0)
Expected: Weather forecast
Actual:   Hello, world!
          ↑ (pos 0)

   at Microsoft.AspNetCore.Components.E2ETest.Tests.ThreadingAppTest.HasFetchDataPage() in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/ThreadingAppTest.cs:line 91
   at InvokeStub_ThreadingAppTest.HasFetchDataPage(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Assert.Equal() Failure
          ↓ (pos 0)
Expected: Counter
Actual:   Hello, world!
          ↑ (pos 0)

   at Microsoft.AspNetCore.Components.E2ETest.Tests.ThreadingHostedAppTest.NavMenuHighlightsCurrentLocation() in /home/vsts/work/1/s/src/Components/test/E2ETest/Tests/ThreadingAppHostedTest.cs:line 56
   at InvokeStub_ThreadingHostedAppTest.NavMenuHighlightsCurrentLocation(Object, Object, IntPtr*)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Can someone take a look at what is causing these tests to fail?

@eerhardt
Copy link
Member Author

eerhardt commented Mar 1, 2024

@mangod9 - we are getting crashes on the macOS leg (both here and in #54055). It looks like we are getting core dumps uploaded under MacOS_Test_Dumps: https://dev.azure.com/dnceng-public/public/_build/results?buildId=585869&view=artifacts&pathAsName=false&type=publishedArtifacts.

Can you take a look? I think this just recently started with the latest runtime updates, as they weren't happening in previous builds in #54055.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 1, 2024

I think we need the last 3 commits from https://github.com/dotnet/aspnetcore/pull/54236/commits to fix the Components E2E failures

@build-analysis build-analysis bot mentioned this pull request Mar 1, 2024
Closed
3 tasks
@eerhardt eerhardt requested a review from a team as a code owner March 1, 2024 20:36
@eerhardt
Copy link
Member Author

eerhardt commented Mar 1, 2024

I think we need the last 3 commits from https://github.com/dotnet/aspnetcore/pull/54236/commits to fix the Components E2E failures

Thanks. I cherry-picked them into this branch.

@BrennanConroy
Copy link
Member

BrennanConroy commented Mar 2, 2024

Merge? And close the other PR and let darc open a new one?

@mangod9
Copy link
Member

mangod9 commented Mar 2, 2024

Yeah assuming some changes from this build are required. We will have to bisect the next few builds to figure out which change has broken the MacOS test.

@eerhardt eerhardt merged commit c7c76d7 into dotnet:main Mar 2, 2024
@eerhardt eerhardt deleted the UpdateRuntime branch March 2, 2024 02:05
@mangod9
Copy link
Member

mangod9 commented Mar 2, 2024

to investigate the failure can we pick up "9.0.0-preview.3.24129.2" to check if that fails?

@eerhardt
Copy link
Member Author

eerhardt commented Mar 2, 2024

to investigate the failure can we pick up "9.0.0-preview.3.24129.2" to check if that fails?

Moving the investigation back to #54055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eerhardt @wtgodbe @BrennanConroy @mangod9 @MackinnonBuck