Skip to content

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Jan 4, 2024

  • Adds a Shared.JS folder to contain all the build configs that are common/base/shared across all our component "JS" packages.
  • Adds 'Shared.JS/rollup.config.mjs' to define a base config that packages can customize.
  • Adds 'Shared.JS/tsconfig.json' base config that other packages can extend.
  • Updates individual packages to generate the bundler config based on 'Shared.JS/rollup.config.mjs'

@javiercn javiercn requested a review from a team as a code owner January 4, 2024 19:47
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 4, 2024
@javiercn javiercn changed the title [Blazor] Centralize our build setup [Blazor] Centralize our JS build setup Jan 4, 2024
@javiercn javiercn closed this Jan 4, 2024
@javiercn javiercn reopened this Jan 4, 2024
@javiercn
Copy link
Member Author

javiercn commented Jan 4, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@javiercn javiercn force-pushed the javiercn/move-to-rollup-other-blazor-js branch 2 times, most recently from 575139e to 3c68915 Compare January 4, 2024 22:00
@javiercn javiercn force-pushed the javiercn/blazor-centralize-build-configuration branch from dfb81eb to f36fe99 Compare January 5, 2024 07:34
@javiercn javiercn force-pushed the javiercn/move-to-rollup-other-blazor-js branch from 9913d5a to f9ae20a Compare January 5, 2024 07:53
@javiercn javiercn force-pushed the javiercn/blazor-centralize-build-configuration branch 2 times, most recently from b93144b to 6e3a64f Compare January 5, 2024 10:06
Base automatically changed from javiercn/move-to-rollup-other-blazor-js to main January 5, 2024 11:35
@javiercn javiercn force-pushed the javiercn/blazor-centralize-build-configuration branch from 6e3a64f to 15c6a58 Compare January 5, 2024 11:45
@javiercn javiercn force-pushed the javiercn/blazor-centralize-build-configuration branch from 15c6a58 to bee21d7 Compare January 5, 2024 16:47
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@javiercn javiercn merged commit 7b9e6b0 into main Jan 8, 2024
@javiercn javiercn deleted the javiercn/blazor-centralize-build-configuration branch January 8, 2024 07:54
@ghost ghost added this to the 9.0-preview1 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants