Skip to content

fix: Added missing AddOptions() to AddLocalization. #53016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halter73 merged 1 commit into from
Jan 8, 2024
Merged

fix: Added missing AddOptions() to AddLocalization. #53016

halter73 merged 1 commit into from
Jan 8, 2024

Conversation

@HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Dec 27, 2023 •
edited
Loading

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

There are two AddLocalization methods that do the same thing, but the second one skips the AddOptions call.
Since this is a trivial fix, some things are missed

Description

{Detail}

Fixes #{bug number} (in this specific format)

@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Dec 27, 2023
@ghost
Copy link

ghost commented Dec 27, 2023

Thanks for your PR, @HavenDV. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Dec 27, 2023

@halter73 can you please review this? Thanks!

@ghost
Copy link

ghost commented Jan 4, 2024

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 4, 2024
halter73
halter73 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@halter73 halter73 merged commit b146975 into dotnet:main Jan 8, 2024
@ghost ghost added this to the 9.0-preview1 milestone Jan 8, 2024
@HavenDV HavenDV deleted the patch-1 branch January 8, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

Assignees

@halter73 halter73

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

9.0-preview1

Development

Successfully merging this pull request may close these issues.

3 participants

@HavenDV @mkArtakMSFT @halter73