Skip to content

Set IExceptionHandlerFeature on DeveloperExceptionPageMiddleware #52688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrennanConroy merged 5 commits into from
Dec 10, 2025
Merged

Set IExceptionHandlerFeature on DeveloperExceptionPageMiddleware #52688

BrennanConroy merged 5 commits into from
Dec 10, 2025

Conversation

@Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Dec 9, 2023

Fixes #49195

@ghost ghost added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member labels Dec 9, 2023
@ghost
Copy link

ghost commented Dec 9, 2023

Thanks for your PR, @Kahbazi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Kahbazi Kahbazi added feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Dec 9, 2023
JamesNK
JamesNK previously requested changes Dec 18, 2023
View reviewed changes
@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 26, 2023
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment Feb 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 13, 2024
@wtgodbe wtgodbe removed the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 20, 2024
@adityamandaleeka
Copy link
Member

adityamandaleeka commented Jun 21, 2024

@Kahbazi Are you still interested in working on this?

@Kahbazi
Copy link
Member Author

Kahbazi commented Jun 24, 2024

@adityamandaleeka Sorry I missed this PR, I will work on it this weekend.

@BrennanConroy BrennanConroy enabled auto-merge (squash) December 9, 2025 22:52
@build-analysis build-analysis bot mentioned this pull request Dec 10, 2025
Open
This was referenced Dec 10, 2025
Open
Open
@BrennanConroy BrennanConroy merged commit 94d8301 into dotnet:main Dec 10, 2025
30 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 11.0-preview1 milestone Dec 10, 2025
@Kahbazi Kahbazi deleted the kahbazi/DeveloperPageException branch December 10, 2025 09:06
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@JamesNK JamesNK JamesNK left review comments

Assignees

@BrennanConroy BrennanConroy

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member feature-diagnostics Diagnostic middleware and pages (except EF diagnostics) pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

11.0-preview1

Development

Successfully merging this pull request may close these issues.

Always set IExceptionHandlerFeature from UseDeveloperExceptionPage

5 participants

@Kahbazi @adityamandaleeka @JamesNK @BrennanConroy @wtgodbe