Skip to content

Added ppc64le architecture to support testcases on power machine. #48638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halter73 merged 3 commits into from
Jun 16, 2023
Merged

Added ppc64le architecture to support testcases on power machine. #48638

halter73 merged 3 commits into from
Jun 16, 2023

Conversation

@ashutoshjadhav9
Copy link
Contributor

@ashutoshjadhav9 ashutoshjadhav9 commented Jun 6, 2023 •
edited
Loading

Some testcases were failing with "unknown architecture ppc64le" error.
Below testcases were failing due to missing ppc64le architecture.

  1. Microsoft.AspNetCore.FunctionalTests.dll
  2. Microsoft.AspNetCore.Hosting.FunctionalTests.dll
  3. ServerComparison.FunctionalTests.dll

So, we have added the power architecture to support those testcases.
Now all the testcases related to power architecture are passing.

@ghost ghost added area-hosting Includes Hosting community-contribution Indicates that the PR has been added by a community member labels Jun 6, 2023
@ghost
Copy link

ghost commented Jun 6, 2023

Thanks for your PR, @ashutoshjadhav9. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ashutoshjadhav9
Copy link
Contributor Author

ashutoshjadhav9 commented Jun 6, 2023

@dotnet-policy-service agree

@dotnet-policy-service agree

@ghost
Copy link

ghost commented Jun 15, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 15, 2023
halter73
halter73 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever have to do this again, we should delete RuntimeArchitecture just start using Architecture directly in our integration tests.

@halter73 halter73 merged commit 70167f8 into dotnet:main Jun 16, 2023
@ghost ghost added this to the 8.0-preview6 milestone Jun 16, 2023
@halter73
Copy link
Member

halter73 commented Jun 16, 2023

Thanks @ashutoshjadhav9!

@ashutoshjadhav9
Copy link
Contributor Author

ashutoshjadhav9 commented Dec 11, 2025

@ashutoshjadhav9 test notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@halter73 halter73

Labels

area-hosting Includes Hosting community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Milestone

8.0-preview6

Development

Successfully merging this pull request may close these issues.

2 participants

@ashutoshjadhav9 @halter73