Conversation
ghost
added
the
area-infrastructure
Merged
mitchdenny
approved these changes
Jan 9, 2023
dougbu
approved these changes
Jan 10, 2023
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Let's see what happens w/ official builds once this goes in. Are you pretty sure this package version contains the changes we need to support newer binary logs❔
Member
Author
|
Yeah, this is the one Matt claims fixes the issue in dotnet/arcade#11995 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the official build break introduced by #45879. We can't get rid of these SourceIndex properties and use the arcade defaults, because these are used directly later in this file.