Skip to content

[Blazor WebAssembly] Change web app manifest extension to “webmanifest”#43756

Merged
TanayParikh merged 1 commit intodotnet:mainfrom
christianliebel:webmanifest-ext
Jan 24, 2023
Merged

[Blazor WebAssembly] Change web app manifest extension to “webmanifest”#43756
TanayParikh merged 1 commit intodotnet:mainfrom
christianliebel:webmanifest-ext

Conversation

@christianliebel
Copy link
Contributor

@christianliebel christianliebel commented Sep 5, 2022 •
edited
Loading

[Blazor WebAssembly] Change web app manifest extension to “webmanifest”

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Changes web app manifest extension from "json" to "webmanifest"

Description

Changes the extension of the web application manifest included by the Blazor WebAssembly project templates from "json" to "webmanifest", the official file extension. This helps servers to deliver the file with the official media type (application/manifest+json).

Fixes #43755

@christianliebel christianliebel requested review from a team and Pilchie as code owners September 5, 2022 11:31
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Sep 5, 2022
@ghost
Copy link

ghost commented Sep 5, 2022

Thanks for your PR, @christianliebel. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dnfadmin
Copy link

dnfadmin commented Sep 5, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@christianliebel christianliebel mentioned this pull request Sep 5, 2022
Closed
1 task
javiercn
javiercn reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests likely need to be updated and the docs might also need to be updated.

We should ping guardrex about the docs after this is merged.

@christianliebel christianliebel changed the title Change web app manifest extension to “webmanifest” [Blazor WebAssembly] Change web app manifest extension to “webmanifest” Sep 5, 2022
This was referenced Sep 5, 2022
Closed
Merged
@christianliebel
Copy link
Contributor Author

christianliebel commented Sep 5, 2022

@javiercn I have updated the tests. A Blazor Server test still fails because dotnet publish does not work. But this should have nothing to do with my changes. Could you look into this for me?

Let me know if you need any help with the docs.

@TanayParikh TanayParikh assigned TanayParikh and unassigned javiercn Jan 13, 2023
@TanayParikh
Copy link
Contributor

TanayParikh commented Jan 13, 2023

Hey @christianliebel, thanks for the PR. We're ready to take this in now. Could you please resolve the merge conflict, and I'll look into any CI flakiness if required.

@TanayParikh TanayParikh added this to the .NET 8 Planning milestone Jan 13, 2023
@DamianEdwards DamianEdwards mentioned this pull request Jan 13, 2023
Closed
@christianliebel
Copy link
Contributor Author

christianliebel commented Jan 14, 2023

@TanayParikh Done!

@build-analysis build-analysis bot mentioned this pull request Jan 14, 2023
Open
5 tasks
@TanayParikh
Copy link
Contributor

TanayParikh commented Jan 24, 2023

/azp run aspnetcore-quarantined-pr

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 24, 2023

Azure Pipelines successfully started running 1 pipeline(s).

TanayParikh
TanayParikh approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@TanayParikh TanayParikh merged commit d0c9e0e into dotnet:main Jan 24, 2023
@ghost ghost modified the milestones: .NET 8 Planning, 8.0-preview1 Jan 24, 2023
@TanayParikh
Copy link
Contributor

TanayParikh commented Jan 24, 2023

Thanks @christianliebel!

I think thats all the webmanifest PRs. Please let me know if I missed any!

@christianliebel christianliebel deleted the webmanifest-ext branch January 24, 2023 21:39
@christianliebel
Copy link
Contributor Author

christianliebel commented Jan 24, 2023

@TanayParikh Looks good, thanks!!

@ghost
Copy link

ghost commented Jan 24, 2023

Hi @christianliebel. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@tomasz-soltysik tomasz-soltysik mentioned this pull request Apr 4, 2024
Closed
1 task
@shethaadit shethaadit mentioned this pull request Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn left review comments

@Pilchie Pilchie Awaiting requested review from Pilchie

+1 more reviewer

@TanayParikh TanayParikh TanayParikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TanayParikh TanayParikh

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

8.0-preview1

Development

Successfully merging this pull request may close these issues.

[Blazor WebAssembly Project Template] Change web app manifest extension to “webmanifest”

4 participants

@christianliebel @dnfadmin @TanayParikh @javiercn