[Blazor] Dynamic authentication requests #42692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
commented
Jul 12, 2022
src/Components/WebAssembly/WebAssembly.Authentication/src/Interop/AuthenticationService.ts
Show resolved
Hide resolved
javiercn
commented
Jul 12, 2022
| <StaticWebAssetProjectConfiguration Include="@(_IdentityUI)" /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
Member
Author
There was a problem hiding this comment.
This just fixes how we consume identity UI as a class library, which was broken.
Member
There was a problem hiding this comment.
It would be good to add a comment indicating what all this stuff is for. i.e., in what way it would be broken otherwise, and why it has to be fixed here rather than in whatever added the identity UI files to the project in the first place.
Hopefully you can appreciate that basically nobody in the world would have any idea why we're doing this apart from you :)
Member
Author
There was a problem hiding this comment.
I'll add a comment for this.
javiercn
changed the title
TanayParikh
added
area-blazor
src/Components/WebAssembly/WebAssembly.Authentication/src/Interop/AuthenticationService.ts
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/Interop/AuthenticationService.ts
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/Models/InteractiveRequestOptions.cs
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/Models/InteractiveRequestOptions.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/Models/InteractiveRequestOptions.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/NavigationManagerExtensions.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/NavigationManagerExtensions.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/NavigationManagerExtensions.cs
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/NavigationManagerExtensions.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/NavigationManagerExtensions.cs
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs
Show resolved
Hide resolved
...omponents/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs
Outdated
Show resolved
Hide resolved
...omponents/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs
Outdated
Show resolved
Hide resolved
...omponents/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs
Show resolved
Hide resolved
...omponents/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/testassets/Wasm.Authentication.Client/Pages/UserPreferences.razor
Outdated
Show resolved
Hide resolved
src/Components/WebAssembly/testassets/Wasm.Authentication.Client/Shared/RedirectToLogin.razor
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Aug 3, 2022
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Looks great!
I think there are still a few details about the JSON serialization trimming suppressions to be solved (preferably by switching to use the source generator - that should make things much simpler for you).
Besides that everything looks good so I'll approve now.
Address feedback Co-authored-by: Steve Sanderson <[email protected]>
javiercn
force-pushed
the
javiercn/dynamic-authentication-requests
branch
from
5ff0b4c to
1c22136
Compare
ghost
added this to the
93 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42580
Adds a new type InteractiveRequestOptions that contains the data developers can use to customize the authentication flows. The data is passed in through the State parameter to the remoteauthenticatorviewcore which then handles the authentication process.