Skip to content

Sync shared code from runtime#41317

Merged
BrennanConroy merged 1 commit intomainfrom
github-action/sync-runtime-1650614654
Apr 30, 2022
Merged

Sync shared code from runtime#41317
BrennanConroy merged 1 commit intomainfrom
github-action/sync-runtime-1650614654

Conversation

@github-actions
Copy link
Contributor

This PR was automatically generated to sync shared code changes from runtime. Fixes #18943

{
case (int)HttpStatusCode.Continue:
return BytesStatus100;
return "100"u8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the devil is this? A new C# feature for representing UTF8 bytes?

There seem to be errors when building here. We might not have a recent enough SDK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspect we're now much closer to an SDK or a compiler that can handle this. Suggest updating to the LKG SDK in this PR if you can't wait 'til Monday for our usual SDK bump.

@Tratcher
Copy link
Member

Blocked by #41158

@Tratcher Tratcher self-assigned this Apr 22, 2022
@Tratcher Tratcher added the blocked The work on this issue is blocked due to some dependency label Apr 22, 2022
@BrennanConroy
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dougbu
Copy link
Contributor

dougbu commented Apr 29, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dougbu
Copy link
Contributor

dougbu commented Apr 29, 2022

Oops, that might be a wasted run given failure of what @BrennanConroy started

@JamesNK
Copy link
Member

JamesNK commented Apr 29, 2022

Is the compiler updated with the SDK? A new C# compiler is required for the new syntax in this sync.

@Tratcher
Copy link
Member

@BrennanConroy and @sebastienros (?) are already looking at an SDK update, but there are other challenges taking the latest SDK.

@Tratcher
Copy link
Member

#41449

@BrennanConroy
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@BrennanConroy BrennanConroy merged commit ac39742 into main Apr 30, 2022
@BrennanConroy BrennanConroy deleted the github-action/sync-runtime-1650614654 branch April 30, 2022 23:26
@ghost ghost added this to the 7.0-preview5 milestone Apr 30, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blocked The work on this issue is blocked due to some dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

5 participants