[WIP] ANCM + Arm64 + helix #39420
[WIP] ANCM + Arm64 + helix #39420
Conversation
ghost
added
the
area-infrastructure
| @@ -1,5 +1,9 @@ | |||
| # We only want to run full helix matrix on main | |||
| pr: none | |||
| pr: | |||
| <!-- aspnetcore-helix-matrix[-internal] (helix-matrix.yml) and RunHelix.ps1 --> | ||
| <!-- aspnetcore-quarantined-tests (quarantined-tests.yml) and RunHelix.ps1 -RunQuarantinedTests --> | ||
| <ItemGroup> | ||
| <!-- Linux --> |
|
@dotnet/aspnet-build how does this tweak look for our arm64 testing, I've asked core-eng to turn on IIS for arm64 so we'll be starting to run tests (once we get things working), but basically I split out the windows arm64 queue into its own group for the arm64 native build and split it out from the other queues |
| publishOnError: true | ||
|
|
||
| # Helix ARM64 | ||
| - ${{ if ne(variables['System.TeamProject'], 'internal') }}: |
There was a problem hiding this comment.
Why do this only for public runs e.g. are you dealing w/ another missing internal Helix queue❔ aspnetcore-helix-matrix-internal is disabled in any case.
There was a problem hiding this comment.
I just copied this from the PR that deleted this job and brought it back, perhaps there are changes that were done since, so we can drop the condition now?
| -arch x64 | ||
| -pack | ||
| -all | ||
| displayName: Build x64/arm64 |
There was a problem hiding this comment.
Need /p:CrossgenOutput=false here too; might need it in the next build step as well
| - script: .\eng\build.cmd -ci -arch arm64 -noBuildRepoTasks -NoRestore -test -all | ||
| -projects eng\helix\helix.proj /p:IsHelixWindowsArmCheck=true | ||
| /p:IsHelixJob=true /p:RunTemplateTests=true | ||
| /p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log |
There was a problem hiding this comment.
Generally, be consistent w/ property settings in all three build steps. This line appears multiple times in the other job for example.
Try to get iis tests running on arm64 helix queue
Tests are running now but most no-op as IIS/IISExpress are not installed