Fix EmptyBodyBehavior with empty content-type #38092
Conversation
BrennanConroy
added
area-mvc
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Nice. I think there's a new feature we can use instead of checking for Content-Length headers, we should consider updating the code to use that.
|
|
||
| if (formatter == null) | ||
| { | ||
| if (AllowEmptyBody && httpContext.Request.ContentLength == 0) |
There was a problem hiding this comment.
@Tratcher isn't there a better way to check for empty bodies?
There was a problem hiding this comment.
| { | ||
| if (AllowEmptyBody && httpContext.Request.ContentLength == 0) | ||
| { | ||
| return; |
There was a problem hiding this comment.
I think you might need to do bindingContext.Result = ModelBindingResult.Success(model: null);. See the comment on Line 178.
There was a problem hiding this comment.
Is there a test I should write for this? I'm not sure how this is visible
There was a problem hiding this comment.
Hmm, I think an actual case where problematic behavior might be observable if if you have a [FromBody] property. But maybe we could just write a unit test that verify IsModelSet == true?
BrennanConroy
force-pushed
the
brecon/emptyBody
branch
from
0fd9346 to
ff7b27a
Compare
ghost
added this to the
Fixes #36466