Skip to content

Fix templates with Windows auth option #37607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebastienros merged 5 commits into from
Oct 19, 2021
Merged

Fix templates with Windows auth option #37607

sebastienros merged 5 commits into from
Oct 19, 2021

Conversation

@sebastienros
Copy link
Member

@sebastienros sebastienros commented Oct 16, 2021

Fixes #37556

@sebastienros sebastienros requested review from a team and Pilchie as code owners October 16, 2021 00:33
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 16, 2021
@sebastienros sebastienros requested review from HaoK and Tratcher October 16, 2021 00:33
@sebastienros
Copy link
Member Author

sebastienros commented Oct 16, 2021 •
edited
Loading

I manually verified Razore Pages CS (razor) and StarterWeb (mvc) templates.
The Razor Pages with FS doesn't have a WindowsAuth option.
I updated the Blazor Server template but it's not working for me, even without the option: Had some stale files in the same folder.

@HaoK
Copy link
Member

HaoK commented Oct 16, 2021

@sebastienros I got that error in the past, I think you just need to uninstall all older 6.0 sdks, as I think that was how I got rid of that error

timheuer
timheuer previously requested changes Oct 16, 2021
View reviewed changes
@Tratcher
Copy link
Member

Tratcher commented Oct 16, 2021

Other templates with windows auth:

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/Properties/launchSettings.json

Line 4 in f306bff

"windowsAuthentication": true,

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/Properties/launchSettings.json

Line 4 in f306bff

"windowsAuthentication": true,

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/Properties/launchSettings.json

Line 5 in f306bff

"windowsAuthentication": true,

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-FSharp/Properties/launchSettings.json

Line 5 in f306bff

"windowsAuthentication": true,

pranavkm
pranavkm suggested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version looks suspect

@sebastienros
Copy link
Member Author

sebastienros commented Oct 18, 2021

@Tratcher I checked the other templates. It looks like the argument was copy pasted in launchSettings.json files but this is not intended to work in the projects, unless for webapi c# which seems to be missing the windows auth code too. If you take a look at EmptyWeb templates for instance their csproj is very empty, so is the Program.cs file. Do we want to add Windows auth at that point? I think it's out of the scope of the current issue we are fixing.

@Tratcher
Copy link
Member

Tratcher commented Oct 18, 2021 •
edited
Loading

I assume we'd want to fix any template that had an -auth Windows command like WebApi, razor, mvc, blazorserver, etc. Follow up with @blowdart.

@blowdart
Copy link
Contributor

blowdart commented Oct 18, 2021

That's a fair assumption

Tratcher
Tratcher approved these changes Oct 18, 2021
View reviewed changes
@sebastienros sebastienros requested a review from timheuer October 18, 2021 22:16
@sebastienros sebastienros dismissed timheuer’s stale review October 19, 2021 00:08

Reacted to comments

@sebastienros sebastienros merged commit c3df4fc into main Oct 19, 2021
@sebastienros sebastienros deleted the sebros/windowsauth branch October 19, 2021 00:08
@ghost ghost added this to the 7.0-preview1 milestone Oct 19, 2021
@sebastienros
Copy link
Member Author

sebastienros commented Oct 19, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1356998325

@github-actions github-actions bot mentioned this pull request Oct 19, 2021
Merged
@Tratcher Tratcher mentioned this pull request Nov 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@HaoK HaoK HaoK approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

@timheuer timheuer Awaiting requested review from timheuer

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

Windows auth template doesn't include Kestrel auth components

7 participants

@sebastienros @HaoK @Tratcher @blowdart @timheuer @pranavkm