Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 28, 2021

Backport of #37056 to release/6.0

/cc @wtgodbe @HaoK

Customer Impact

Ugly UI alignment issue
https://user-images.githubusercontent.com/6537861/135042048-a29a2de6-76e4-4421-8c15-cbe2e62e6b95.png

Testing

Manual

Risk

Low, just tweaking spans to be outside of a li, or removing unnecessary spans

@github-actions github-actions bot requested a review from Pilchie as a code owner September 28, 2021 16:14
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 28, 2021
@HaoK
Copy link
Member

HaoK commented Sep 28, 2021

@Pilchie can we take this for 6.0?

@Pilchie
Copy link
Member

Pilchie commented Sep 28, 2021

Approved for .NET 6 GA.

@HaoK
Copy link
Member

HaoK commented Sep 28, 2021

@dotnet/aspnet-build can we get this merged? Thanks!

@dougbu
Copy link
Contributor

dougbu commented Sep 28, 2021

I'm not the right person to approve this change and I haven't seen anything indicating it's approved for GA. Please gather those things.

Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been approved and checked into main, this is a backport and Kevin has signed off

@dougbu
Copy link
Contributor

dougbu commented Sep 28, 2021

Kevin has signed off

Of course if @Pilchie says "yes" so do I 😃

@dougbu dougbu merged commit 0168a9d into release/6.0 Sep 28, 2021
@dougbu dougbu deleted the backport/pr-37056-to-release/6.0 branch September 28, 2021 22:09
@ghost ghost added this to the 6.0.0 milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants