[Release/6.0] Fix uncompressed scenarios with DisableBuffering #37042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Tratcher
added
the
Servicing-consider
|
Hi @Tratcher. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
adityamandaleeka
added
Servicing-approved
wtgodbe
approved these changes
Sep 28, 2021
Member
Author
|
@dotnet/aspnet-build merge please. |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36960
Backport of #37022
Description
Applications that add the response compression middleware and call the DisableBuffering API are seeing responses compressed that should not have been, and in a way that the client is not able to decompress them (missing headers, appears as data corruption).
Customer Impact
dotnet-monitor is blocked from upgrading to 6.0 due to these responses that appear corrupted.
Regression?
From 5.0
Risk
This middleware is opt-in, and the DisableBuffering API is uncommon. Unit test coverage has been added for this negative case.
Verification
Packaging changes reviewed?