Skip to content

Conversation

@github-actions
Copy link
Contributor

Backport of #36929 to release/6.0

/cc @wtgodbe

Customer Impact

Testing

Risk

@github-actions github-actions bot requested a review from a team as a code owner September 24, 2021 18:46
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 24, 2021
@wtgodbe wtgodbe enabled auto-merge (squash) September 24, 2021 18:47
@wtgodbe wtgodbe disabled auto-merge September 24, 2021 18:51
@wtgodbe wtgodbe mentioned this pull request Sep 24, 2021
@dougbu
Copy link
Contributor

dougbu commented Sep 24, 2021

Did you kick off a helix-matrix run to check this out❔

@wtgodbe
Copy link
Member

wtgodbe commented Sep 24, 2021

Did you kick off a helix-matrix run to check this out❔

No, it's the same queue we've been running on for >1 year. But, couldn't hurt: https://dev.azure.com/dnceng/public/_build/results?buildId=1385152&view=results

@wtgodbe
Copy link
Member

wtgodbe commented Sep 25, 2021

Alpine queue was clean on the helix run

@dougbu
Copy link
Contributor

dougbu commented Sep 25, 2021

What's the deal w/ Microsoft.AspNetCore.Components.Routing.RouteTableFactoryTests.CanCacheRouteTable on Ubuntu❔

/cc @javiercn @pranavkm @SteveSandersonMS

@BrennanConroy
Copy link
Member

I quarantined it yesterday (on main)
#36888

Looks like it's a static class with static properties, that doesn't make for good testing since anything else in the process might also touch it and affect the test.

@wtgodbe wtgodbe merged commit 20b820f into release/6.0 Sep 25, 2021
@wtgodbe wtgodbe deleted the backport/pr-36929-to-release/6.0 branch September 25, 2021 02:32
@ghost ghost added this to the 6.0.0 milestone Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants