-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Update spa-templates submodule to reference 6.0 branch #36932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any of those changes to the spa-templates repo that we need for RC2 should be Tactics approved at this point. We're locking down RC2 rapidly now. |
|
There are no changes in spa-templates in 6.0 coming in, we're just creating the branch for release/6.0 so that the TFM update in main doesn't break the 6.0 branches. We could also wait to do that until rc2 is done so that this branch is unaffected, and only update the submodule reference in release/6.0 |
|
Ok, sounds good to me. |
|
Looks good but you hit a flaky test |
Done yesterday #36887, not in 6.0 though |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Changed the base to 6.0. I'll merge the TFM update PR to spa-templates' main branch once rc2 is officially done. |
spa-templates' main branch is going to
net7.0, so we've created arelease/6.0branch which our 6.0 branches need to reference. Doing this in rc2 so subsequent builds of that branch don't break (there are still incoming changes). Commit isn't changing for the submodule because it's currently the same commit as inmain. CC @Pilchie since this goes into rc2