Fix Missing RZ10012 diagnostic for components written in certain cultures
#36907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
pranavkm
approved these changes
Sep 24, 2021
mkArtakMSFT
added
the
Servicing-consider
|
Hi @TanayParikh. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
ericstj
reviewed
Sep 24, 2021
src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs
Show resolved
Hide resolved
Member
tarekgh
approved these changes
Sep 24, 2021
dougbu
reviewed
Sep 24, 2021
src/Razor/Microsoft.AspNetCore.Razor.Language/src/RazorCodeGenerationOptions.cs
Show resolved
Hide resolved
TanayParikh
added
Servicing-approved
Contributor
Author
|
@dotnet/aspnet-build requesting merge: E2E Validation Successful: |
TanayParikh
added a commit
that referenced
this pull request
Sep 24, 2021
…ltures (#36907) * Update test to account for localized component names * Support Titlecase/OtherLetter * Update ComponentChildContentIntegrationTest.cs * Add SupportLocalizedComponentNames Configurable Property * PR Feedback * Test supportLocalizedComponentNames configuration * PR Feedback * Update PublicAPI.Unshipped.txt * RC2 Tooling Support for Support Localized Component Names (#36936)
TanayParikh
added a commit
that referenced
this pull request
Sep 24, 2021
…ertain cultures (#36949) * Fix Missing `RZ10012` diagnostic for components written in certain cultures (#36907) * Update test to account for localized component names * Support Titlecase/OtherLetter * Update ComponentChildContentIntegrationTest.cs * Add SupportLocalizedComponentNames Configurable Property * PR Feedback * Test supportLocalizedComponentNames configuration * PR Feedback * Update PublicAPI.Unshipped.txt * RC2 Tooling Support for Support Localized Component Names (#36936) * Update src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorIntermediateNodeLoweringPhase.cs * Update src/Razor/Microsoft.AspNetCore.Razor.Language/src/RazorCodeGenerationOptionsBuilder.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blazor expects components to begin with an uppercase letter. Certain cultures do not differentiate between upper/lowercase characters. As such, components named in those cultures were not getting the
RZ10012diagnostic. Due to the missing diagnostic, some VS code actions were also unavailable.Note: There is a companion PR to this (internal SDK) which will need to consume the changes of this PR for the final solution to work. This will be done after this PR is merged, and we trigger a "dependency update" between the base
release/6.0-rc2branch we're targeting here, and therelease/6.0.1xx-rc2in thedotnet/sdkrepo.Customer Impact
Ensure components named using characters from cultures which do not differentiate between upper/lowercase still get diagnostics and code actions (ex. GB18030
繁体字).For an unrecognized component
繁体字, Blazor will silently output<繁体字></繁体字>as markup instead of providing a warning message indicating this may have been intended to be a component. As a result of the missing warning message, Visual Studio code actions (lightbulbs) for creating a component of name繁体字, or adding a missing using statement will not appear.Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
Addresses https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1408782