Remove System.Security.Permissions closure #36828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `cherry-pick` e58a6c2 - see dotnet/runtime#57816 (comment) - also reacting to dotnet/runtime#58731 - undo much of 18a61fb
- `cherry-pick` 888e03a - remove references to System.Security.Permissions and its closure - only mentions are in eng/PackageOverrides.txt and eng/PlatformManifest.txt - those files will remain unused until we update them in the run-up to 6.0.1 - may see some package refs for SSP and its closure elsewhere but this does not impact targeting pack content - also remove duplication between `@(AspNetCoreReferenceAssemblyPath)` additions (for efficiency) nit: Only need to exclude System.Net.Quic from `@(_AvailableRuntimeRefAssemblies)` - Crypto.Pkcs is **not** present in the transport package - other disallowed entries aren't present in the transport package or our dependency closure
dougbu
added
the
area-infrastructure
Contributor
Author
|
/fyi @ViktorHofer @ericstj it took us a while to catch up w/ dotnet/runtime but we're ready to do this 🎉 Note to self: triple-check shared Fx and targeting pack content against a recent build of 'main' |
wtgodbe
approved these changes
Sep 22, 2021
ericstj
approved these changes
Sep 22, 2021
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Looks good. Glad we can remove these special cases.
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[main] React to dotnet/runtime#57816 (#36155)
cherry-picke58a6c2[main] Cleanup remaining SSP references (#36248)
cherry-pick888e03a@(AspNetCoreReferenceAssemblyPath)additions (for efficiency)nit: Only need to exclude System.Net.Quic from
@(_AvailableRuntimeRefAssemblies)