Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 15, 2021

Backport of #36570 to release/6.0

/cc @davidfowl

…rnal host builder, we copy the sources from the ConfigurationManager to the internal IConfigurationBuilder and the HostBuilder creates. This results in building configuration twice which can be problematic for performance reasons. Instead, we copy over the already built configuration providers in a custom IConfigurationSource implementation. This change does means the looking at the list of sources will not match the original list of sources though. - Added a test
@github-actions github-actions bot requested a review from Tratcher as a code owner September 15, 2021 21:10
@ghost ghost added the area-runtime label Sep 15, 2021
@davidfowl
Copy link
Member

cc @dotnet/aspnet-build

@sebastienros
Copy link
Member

Tactics approved or not necessary?

@wtgodbe
Copy link
Member

wtgodbe commented Sep 15, 2021

Ask mode starts tomorrow, we can get this in today

@wtgodbe
Copy link
Member

wtgodbe commented Sep 15, 2021

Force merging this since it was green & approved in main, and branches snap in an hour

@wtgodbe wtgodbe merged commit 5cc4786 into release/6.0 Sep 15, 2021
@wtgodbe wtgodbe deleted the backport/pr-36570-to-release/6.0 branch September 15, 2021 23:03
@ghost ghost added this to the 6.0-rc2 milestone Sep 15, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants