[release/6.0] Avoid using TargetFramework in build targets #36545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
javiercn and
pranavkm
as code owners
ghost
added
the
area-mvc
pranavkm
approved these changes
Sep 15, 2021
Contributor
|
@Pilchie for 6.0 consideration. |
Member
|
Approved for .NET 6. |
Contributor
|
@dotnet/aspnet-build could you merge this? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36512 to release/6.0
/cc @pranavkm
Customer Impact
The Microsoft.AspNetCore.Mvc.Testing incorrectly uses the project's TFM to locate one of it's assets rather than baking in the TFM. This is problematic if the project's TFM has any rid specifiers and results in a build error.
Testing
Testing the package manually and we have automated tests
Risk
Low.