Avoid using TargetFramework in build targets #36512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
pranavkm
commented
Sep 14, 2021
| <Project> | ||
|
|
||
| <Import Project="..\..\build\$(TargetFramework)\Microsoft.AspNetCore.Mvc.Testing.targets" /> | ||
| <Import Project="..\..\build\net6.0\Microsoft.AspNetCore.Mvc.Testing.targets" /> |
Contributor
Author
There was a problem hiding this comment.
FYI @wtgodbe this is going in main, but would be affected by the net7.0 TFM change.
Member
There was a problem hiding this comment.
Cool if I just fold this in to that PR?
Contributor
Author
There was a problem hiding this comment.
I was looking to backport this to 6.0 to address this: #36510
Member
There was a problem hiding this comment.
Go for it - I'll make a conflicting change in the other PR to remind myself
javiercn
approved these changes
Sep 15, 2021
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1238343893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36510