Skip to content

Conversation

@jmprieur
Copy link
Contributor

@jmprieur jmprieur commented Sep 13, 2021

Fix https://github.com/aspnet/AspNetCore-ManualTests/issues/828#issuecomment-916732011

PR Title
Fixes the required scopes in the controller for b2c in the Blasorwasm hosted server

PR Description
Fixes the scopes in the controller in the Blasorwasm hosted server (the resource is in the b2c section).
Without this fix, when creating a b2c blazorwasm hosted application the controller won't find the resource as it's in the "AzureADB2C" section, whereas it was searched in the "AzureAD" section.

For repros and details see: Fixes https://github.com/aspnet/AspNetCore-ManualTests/issues/828

@Claire-kangkang, @HaoK

@jmprieur jmprieur requested a review from a team as a code owner September 13, 2021 02:16
@ghost ghost added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member labels Sep 13, 2021
@SteveSandersonMS
Copy link
Member

@HaoK @javiercn This looks believable to me. Do you have any concerns, or can we merge this? It would definitely be good to get it in for RC2.

We'll have to cherry-pick it to main as well.

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@jmprieur I trust you've done due diligence in validating the changes.

@TanayParikh
Copy link
Contributor

/backport to main

@github-actions
Copy link
Contributor

@HaoK
Copy link
Member

HaoK commented Sep 20, 2021

@jmprieur can you fill out the servicing template for this PR, then we'll just need to ping Kevin on this PR to get approval to merge for 6.0 (or maybe this should go to rc2/thru tactics)

Customer Impact

Testing

Risk

@jmprieur
Copy link
Contributor Author

@HaoK : I just improved the description a bit. Is it ok?

@HaoK
Copy link
Member

HaoK commented Sep 20, 2021

Yep I think that should be sufficient, @Pilchie can we get this merged for 6.0?

@Pilchie
Copy link
Member

Pilchie commented Sep 20, 2021

Approved for .NET 6.

@HaoK
Copy link
Member

HaoK commented Sep 20, 2021

@dotnet/aspnet-build can we get this merged?

@dougbu dougbu merged commit 6898987 into dotnet:release/6.0 Sep 20, 2021
@ghost ghost added this to the 6.0.0 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants