Expose ParameterInfo for Minimal Actions API Explorer #36439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Populate the ParameterDescriptor for Minimal Actions parameters with a type that implements IParameterInfoParameterDescriptor so that any custom attributes on the parameter can be inspected. Relates to dotnet#36438.
ghost
added
area-mvc
rafikiassumani-msft
requested review from
captainsafia,
halter73 and
pranavkm
rafikiassumani-msft
added
old-area-web-frameworks-do-not-use
captainsafia
approved these changes
Sep 15, 2021
Member
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
Thanks! This will be helpful for #36525.
Addresses review feedback.
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1238322205 |
Contributor
|
@captainsafia backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Expose ParameterInfo for Minimal Actions API Explorer
Using index info to reconstruct a base tree...
M src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
CONFLICT (content): Merge conflict in src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Expose ParameterInfo for Minimal Actions API Explorer
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
captainsafia
pushed a commit
that referenced
this pull request
Sep 15, 2021
* Expose ParameterInfo for Minimal Actions API Explorer Populate the ParameterDescriptor for Minimal Actions parameters with a type that implements IParameterInfoParameterDescriptor so that any custom attributes on the parameter can be inspected. Relates to #36438. * Remove file-scoped namespace Addresses review feedback.
wtgodbe
pushed a commit
that referenced
this pull request
Sep 15, 2021
* Expose ParameterInfo for Minimal Actions API Explorer Populate the ParameterDescriptor for Minimal Actions parameters with a type that implements IParameterInfoParameterDescriptor so that any custom attributes on the parameter can be inspected. Relates to #36438. * Remove file-scoped namespace Addresses review feedback. Co-authored-by: Martin Costello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Expose ParameterInfo for Minimal Actions API Explorer
PR Description
Populate the
ParameterDescriptorfor Minimal Actions parameters with a type that implementsIParameterInfoParameterDescriptorso that any custom attributes on the parameter can be inspected.Relates to #36438