Fixed duplicate metadata in ModelDataSource #36337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Today when we make endpoints for the ModelDataSource, we apply the callbacks to the EndpointBuilder before creating the endpoint. This happens every time anyone accesses the endpoints property. Instead of re-applying the conventions, we do it once on Build. We also throw if more conventions are added after building. - Added tests
ghost
added
the
davidfowl
added
old-area-web-frameworks-do-not-use
pranavkm
approved these changes
Sep 9, 2021
| { | ||
| foreach (var convention in _conventions) | ||
| // Only apply the conventions once | ||
| var conventions = Interlocked.Exchange(ref _conventions, null); |
Contributor
There was a problem hiding this comment.
It's interlocked because we're worried about Add / Build being called concurrently?
Member
Author
There was a problem hiding this comment.
I'm just being extra defensive. It's unclear if these APIs are intended to be called thread safe. This is just to prevent any corruption.
| // Access endpoints a couple of times to make sure it gets built | ||
| _ = dataSource.Endpoints; | ||
| _ = dataSource.Endpoints; | ||
| _ = dataSource.Endpoints; |
Contributor
There was a problem hiding this comment.
3 is more than a "couple".
Co-authored-by: Pranav K <[email protected]>
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1218396825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34199