Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2021

Backport of #36161 to release/6.0

/cc @captainsafia

@captainsafia
Copy link
Member

@dotnet/aspnet-build Can I get help merging please?

Also, are we expected to get approvals for backport PRs? Seems a little redundant for cases where there is no delta between the original PR and the backport.

@dougbu
Copy link
Contributor

dougbu commented Sep 9, 2021

are we expected to get approvals for backport PRs?

The normal practise I see is for the original author to approve backports to 'release/6.0'. 'release/3.1' and 'release/5.0' of course need additional checks, though infrastructure and test changes are normally fine there.

Can I get help merging please?

Sure❕ Please approve (for good bookkeeping) and, optionally, confirm none of the commits are new here.

@mkArtakMSFT mkArtakMSFT added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Sep 9, 2021
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbu Got it.

Approving. There's no delta between this PR and the other one approved for main.

The test failures are known issues around the PublicAPI.Shipped files since this change includes already approved API changes.

@wtgodbe wtgodbe merged commit 7f635c3 into release/6.0 Sep 9, 2021
@wtgodbe wtgodbe deleted the backport/pr-36161-to-release/6.0 branch September 9, 2021 16:10
@ghost ghost added this to the 6.0-rc2 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants