[release/6.0]: Fix how host configuration is handled in WebApplicationBuilder #36233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The new WebApplicationBuilder merged host configuration and application configuration together into the same configuration source, then applied those changes to the final all as host configuration. This had some bad side effects: - All configuration changes are wrapped in a chained configuration source which prevented updates (that's a runtime bug) - Host configuration could be mutated by changing any value directly in configuration. This meant that different parts of the code base could see a different environment, application name and content root. This change fixes things by snapshotting the immutable host configuration in the constructor and applying it later. Then only applying configuration sources to application configuration, not host configuration. - Added tests
ghost
added
the
Tratcher
approved these changes
Sep 7, 2021
Member
Author
|
cc @dotnet/aspnet-build for merge |
amcasey
added
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36186 to release/6.0
Customer Impact
This bug prevents inconsistent state being observed by various stages of the WebApplicationBuilder and also allows manual configuration reload to work.
Testing
Unit testing and manual testing.
Risk
Low.