[release/6.0] Don't log status messages for debug proxy. Fixes #35292 #36223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
added
the
Servicing-consider
SteveSandersonMS
approved these changes
Sep 7, 2021
Contributor
|
I believe we should be able to merge this without servicing. @dotnet/aspnet-build? |
pranavkm
reviewed
Sep 7, 2021
| // SuppressStatusMessages) because we need the "Now listening on" one to detect the chosen port. | ||
| // Instead, we'll filter out known strings from the passthrough logic. It's legit to hardcode these | ||
| // strings because they are also hardcoded like this inside WebHostExtensions.cs and can't vary | ||
| // according to culture. |
Contributor
There was a problem hiding this comment.
and can't vary according to culture.
I think the correct term to use is uncultured
Contributor
Member
|
Ok merging this then |
ghost
added this to the
TanayParikh
removed
the
Servicing-consider
Contributor
|
Removing servicing label too in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36220 to release/6.0
/cc @SteveSandersonMS
Customer Impact
During development, the wasm debug server was logging confusing and misleading messages. This fixes that.
Testing
Manual testing. We don't automate tests about the log output from the debug server.
Risk
Low. It only affects the development-time experience, nothing in production. And it's a pretty simple change.