[release/6.0] Properly reject non-json FromBody parameter binding #36118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
BrennanConroy and
Tratcher
as code owners
ghost
added
the
BrennanConroy
requested review from
DamianEdwards,
captainsafia,
davidfowl and
halter73
halter73
reviewed
Sep 3, 2021
| private static partial void RequiredParameterNotProvided(ILogger logger, string parameterType, string parameterName, string source); | ||
|
|
||
| public static void UnexpectedContentType(HttpContext httpContext, string? contentType) | ||
| => UnexpectedContentType(GetLogger(httpContext), contentType ?? "(none)"); |
Member
There was a problem hiding this comment.
I know this was already merged into main but we should respect ThrowOnBadRequest here. Make sure we set the 415 status code on the BadHttpRequestException. All the others use 400 right now.
davidfowl
approved these changes
Sep 3, 2021
Member
|
@dotnet/aspnet-build please merge! |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35976 to release/6.0
/cc @BrennanConroy