Update gitattributes to fix bootstrap CDN SRI #36115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Verified that on disk SHA hash now matches expected SHA384 for bootstrap.bundle.js.min: |
Member
Author
|
We have tests that verify the content is the same for our fallback/CDN content, but the test has logic to strip line endings, so it doesn't catch eol differences https://github.com/dotnet/aspnetcore/blob/main/src/Identity/test/Identity.Test/IdentityUIScriptsTest.cs#L45 |
blowdart
approved these changes
Sep 2, 2021
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1196556713 |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDN integrity checks require byte for byte exact, so line endings are currently causing our CDN checks to fail
I reupdated the files in my repo but it didn't generate any diffs, so hopefully this will fix on a new build
Fixes: https://github.com/aspnet/AspNetCore-ManualTests/issues/865