Skip to content

Avoid using static NullabilityInfoContext #36112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
captainsafia merged 1 commit into from
Sep 3, 2021
Merged

Avoid using static NullabilityInfoContext #36112

captainsafia merged 1 commit into from
Sep 3, 2021

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Sep 2, 2021

Fixes #35990.

Validated manually with the following code snippet:

void Foo(Product? p) { }
var d = Foo;
Parallel.For(0, 100, _ =>
{
    var d1 = RequestDelegateFactory.Create(d);
});
record Product(int Id, string? Title);

BrennanConroy
BrennanConroy reviewed Sep 2, 2021
View reviewed changes
@captainsafia captainsafia force-pushed the safia/fix-static-ncontext branch from c638d47 to 12b1093 Compare September 2, 2021 22:28
@captainsafia captainsafia marked this pull request as ready for review September 3, 2021 00:50
@captainsafia
Copy link
Member Author

captainsafia commented Sep 3, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2021

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1198785303

@github-actions github-actions bot mentioned this pull request Sep 3, 2021
Merged
@captainsafia captainsafia merged commit 0fc6aa5 into main Sep 3, 2021
@captainsafia captainsafia deleted the safia/fix-static-ncontext branch September 3, 2021 17:00
@ghost ghost added this to the 7.0-preview1 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy left review comments

@halter73 halter73 halter73 approved these changes

@davidfowl davidfowl davidfowl approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

Exception when running tests for an app that uses Minimal APIs

6 participants

@captainsafia @halter73 @davidfowl @pranavkm @BrennanConroy